Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat(input): add $setDirty method to the controller of ng-model directive #10049

Closed
wants to merge 1 commit into from
Closed

feat(input): add $setDirty method to the controller of ng-model directive #10049

wants to merge 1 commit into from

Conversation

IShotTheSheriff
Copy link
Contributor

  • extract existing functionality to public method: $setDirty
  • add tests to corresponding changes
  • refactor code to use extracted method

Closes #10038

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@IShotTheSheriff
Copy link
Contributor Author

I'm not sure about the CLA as I signed it Nov 06, 2014 12:36 PST with this GitHub account and matching email.

@caitp
Copy link
Contributor

caitp commented Nov 14, 2014

@Narretz do you want to review this? It sounds like it more or less matches what you were describing.

@caitp caitp added this to the 1.3.4 milestone Nov 14, 2014
@Narretz
Copy link
Contributor

Narretz commented Nov 14, 2014

@caitp will do!

@IShotTheSheriff
Copy link
Contributor Author

Hey I'm still confused about the CLA as email in commit history is indeed the one with CLA signed. I've also updated account setting just to be sure. Can I somehow trigger @mary-poppins CLA recheck?

@IShotTheSheriff
feat(input): add $setDirty method to the controller of ng-model direc…
45568ae 
…tive

- extract existing functionality to public method: $setDirty
- add tests to corresponding changes
- refactor code to use extracted method

Closes #10038
@Narretz Narretz closed this in e8941c0 Nov 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Narretz Narretz

Labels
cla: yes component: forms severity: inconvenient type: feature
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.

$setDirty function should provided by the controller of ng-model directive
5 participants
@IShotTheSheriff @mary-poppins @caitp @Narretz @jeffbcross