Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filterFilter): compare object with custom toString() to primitive #10548

Closed
wants to merge 1 commit into from
Closed

Conversation

@m7r
Copy link
Contributor

@m7r m7r commented Dec 22, 2014

Closes #10464

var obj = new Date(0);
var items = [{test: obj}];
expect(filter(items, '1970').length).toBe(1);
expect(filter(items, 1970).length).toBe(1);
Copy link
Member

@gkalpak gkalpak Dec 22, 2014

Hm...these tests failed on some browsers (Chrome 39 on OS X). The failures are probably related to locale.
Changing new Date(0) to new Date(1970, 0) should fix the issue.

Alternatively, you could change 0 to 86400000 to ensure or timezones are in 1970, but I prefer the former approach.

@gkalpak
Copy link
Member

@gkalpak gkalpak commented Dec 22, 2014

There is a test failing under certain browser-OS combination, which seems to be locale-specific.
Other than that, it LGTM.

@m7r
Copy link
Contributor Author

@m7r m7r commented Dec 22, 2014

How do update the pull request or should I make a new one?

@gkalpak
Copy link
Member

@gkalpak gkalpak commented Dec 22, 2014

@m7r: You can amend the commit and force-push to your branch; the PR will get updated automatically.
(BTW, it is better to make changes on a separate branch (not master). Take also a look here (if you haven't already).)

@m7r
Copy link
Contributor Author

@m7r m7r commented Dec 23, 2014

@gkalpak travis don't like me. What to do now?

@gkalpak
Copy link
Member

@gkalpak gkalpak commented Dec 23, 2014

@m7r: It was a flake. I restarted the job and it's all green now :)

@pkozlowski-opensource pkozlowski-opensource self-assigned this Jan 9, 2015
@pkozlowski-opensource pkozlowski-opensource added this to the 1.3.x milestone Jan 9, 2015
@pkozlowski-opensource
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Jan 9, 2015

@m7r I've left some additional comments to the tests - not a big deal, I can change those while merging, but would like to have your feedback on those.

@pkozlowski-opensource pkozlowski-opensource added this to the 1.4.x milestone Jan 9, 2015
@pkozlowski-opensource pkozlowski-opensource removed this from the 1.3.x milestone Jan 9, 2015
@m7r
Copy link
Contributor Author

@m7r m7r commented Jan 12, 2015

@pkozlowski-opensource why is the milestone set from 1.3.9 to 1.4?

@m7r
Copy link
Contributor Author

@m7r m7r commented Feb 24, 2015

@pkozlowski-opensource what are the next steps?

@petebacondarwin petebacondarwin added this to the 1.4.0-beta.6 / 1.3.15 milestone Mar 3, 2015
@petebacondarwin petebacondarwin removed this from the 1.4.x milestone Mar 3, 2015
@petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented Mar 3, 2015

I tweaked this and landed it. Thanks @m7r

hansmaad pushed a commit to hansmaad/angular.js that referenced this issue Mar 10, 2015
netman92 added a commit to netman92/angular.js that referenced this issue Aug 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants