New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filterFilter): compare object with custom `toString()` to primitive #10548

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@m7r
Contributor

m7r commented Dec 22, 2014

Closes #10464

@googlebot googlebot added the cla: yes label Dec 22, 2014

@gkalpak

View changes

Show outdated Hide outdated test/ng/filter/filterSpec.js
@gkalpak

This comment has been minimized.

Show comment
Hide comment
@gkalpak

gkalpak Dec 22, 2014

Member

There is a test failing under certain browser-OS combination, which seems to be locale-specific.
Other than that, it LGTM.

Member

gkalpak commented Dec 22, 2014

There is a test failing under certain browser-OS combination, which seems to be locale-specific.
Other than that, it LGTM.

@m7r

This comment has been minimized.

Show comment
Hide comment
@m7r

m7r Dec 22, 2014

Contributor

How do update the pull request or should I make a new one?

Contributor

m7r commented Dec 22, 2014

How do update the pull request or should I make a new one?

@gkalpak

This comment has been minimized.

Show comment
Hide comment
@gkalpak

gkalpak Dec 22, 2014

Member

@m7r: You can amend the commit and force-push to your branch; the PR will get updated automatically.
(BTW, it is better to make changes on a separate branch (not master). Take also a look here (if you haven't already).)

Member

gkalpak commented Dec 22, 2014

@m7r: You can amend the commit and force-push to your branch; the PR will get updated automatically.
(BTW, it is better to make changes on a separate branch (not master). Take also a look here (if you haven't already).)

@m7r

This comment has been minimized.

Show comment
Hide comment
@m7r

m7r Dec 23, 2014

Contributor

@gkalpak travis don't like me. What to do now?

Contributor

m7r commented Dec 23, 2014

@gkalpak travis don't like me. What to do now?

@gkalpak

This comment has been minimized.

Show comment
Hide comment
@gkalpak

gkalpak Dec 23, 2014

Member

@m7r: It was a flake. I restarted the job and it's all green now :)

Member

gkalpak commented Dec 23, 2014

@m7r: It was a flake. I restarted the job and it's all green now :)

@pkozlowski-opensource pkozlowski-opensource self-assigned this Jan 9, 2015

@pkozlowski-opensource pkozlowski-opensource added this to the 1.3.x milestone Jan 9, 2015

@pkozlowski-opensource

This comment has been minimized.

Show comment
Hide comment
@pkozlowski-opensource

pkozlowski-opensource Jan 9, 2015

Member

@m7r I've left some additional comments to the tests - not a big deal, I can change those while merging, but would like to have your feedback on those.

Member

pkozlowski-opensource commented Jan 9, 2015

@m7r I've left some additional comments to the tests - not a big deal, I can change those while merging, but would like to have your feedback on those.

@pkozlowski-opensource pkozlowski-opensource modified the milestones: 1.4.x, 1.3.x Jan 9, 2015

@m7r

This comment has been minimized.

Show comment
Hide comment
@m7r

m7r Jan 12, 2015

Contributor

@pkozlowski-opensource why is the milestone set from 1.3.9 to 1.4?

Contributor

m7r commented Jan 12, 2015

@pkozlowski-opensource why is the milestone set from 1.3.9 to 1.4?

@m7r

This comment has been minimized.

Show comment
Hide comment
@m7r

m7r Feb 24, 2015

Contributor

@pkozlowski-opensource what are the next steps?

Contributor

m7r commented Feb 24, 2015

@pkozlowski-opensource what are the next steps?

@petebacondarwin

This comment has been minimized.

Show comment
Hide comment
@petebacondarwin

petebacondarwin Mar 3, 2015

Member

I tweaked this and landed it. Thanks @m7r

Member

petebacondarwin commented Mar 3, 2015

I tweaked this and landed it. Thanks @m7r

hansmaad pushed a commit to hansmaad/angular.js that referenced this pull request Mar 10, 2015

netman92 added a commit to netman92/angular.js that referenced this pull request Aug 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment