Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

docs(jqLite): added missing support for unbind/off with event object as parameter #12291

Closed
wants to merge 2 commits into from

Conversation

gersomvg
Copy link
Contributor

@gersomvg gersomvg commented Jul 7, 2015

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gkalpak
Copy link
Member

gkalpak commented Jul 8, 2015

Not sure what you mean by "missing support for unbind(event) and off(event)".
They seem supported to me.

@gersomvg
Copy link
Contributor Author

gersomvg commented Jul 9, 2015

Have you tested? For me they didn't work with jQlite, until I included the full jQuery lib.

@gkalpak
Copy link
Member

gkalpak commented Jul 9, 2015

@grsmvg, yes I have tested.

Good job, @gkalpak, valiantly resisting the unbeatable urge to be sarcastic about "have you tested".
I'm seeing some serious progress here ! 😄

@Narretz Narretz added this to the Purgatory milestone Jul 13, 2015
@gersomvg
Copy link
Contributor Author

In your example you are not using the exact syntax I'm talking about ;) And glad you're not too sarcastic because we're all here to help an awesome open source project!

The exact syntax that does not seem to be working is like this:

$(someElm).on('click', function(event){
  $(someElm).off(event);
});

And I'm not saying it needs to be fixed, but it should at least be stated correctly in the docs imho.

@gkalpak
Copy link
Member

gkalpak commented Jul 17, 2015

Ah, I see what you mean now :)
(TBH I've never used such a thing.)

I think it would be better phrased as "event object as parameter".
But it also seems trivial to implement...

I would be fine with both 😄

Better description
@gersomvg
Copy link
Contributor Author

The reason someone would use this is because this looked like the only way to unbind one specific event binding without using namespaces (because namespaces are also not supported in jqlite).

I've already ended up using full jQuery lib, but for future readers it's good to change this in docs. See my last commit for a better description.

@gersomvg
Copy link
Contributor Author

Responding to Google bot at top^^ : 'I signed it!'

Pull request is ready for merge.

@googlebot
Copy link

CLAs look good, thanks!

@gersomvg gersomvg changed the title Missing support for unbind(event) and off(event), but not stated docs(jqLite): added missing support for unbind/off with event object as parameter Jul 21, 2015
@gkalpak gkalpak closed this in 7e67e52 Aug 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants