This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): ensure that orphaned elements do not throw errors when animated #12338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsko
force-pushed
the
fix_raf_element_issue
branch
from
21bf33e
to
442f85f
Compare
matsko
added a commit
to matsko/angular.js
that referenced
this pull request
Jul 13, 2015
…n animated This fix ensures that for both `$animateCss` and `$animate` capture the error when an animation takes place where the element is removed from the parent element sometime before or during the preparation stages of the animation. Closes angular#11975 Closes angular#12338
…n animated This fix ensures that for both `$animateCss` and `$animate` capture the error when an animation takes place where the element is removed from the parent element sometime before or during the preparation stages of the animation. Closes angular#11975 Closes angular#12338
matsko
force-pushed
the
fix_raf_element_issue
branch
from
442f85f
to
2c7bdb2
Compare
| @@ -51,6 +51,43 @@ describe("ngAnimate $animateCss", function() { | |||
| describe('when active', function() { | |||
| if (!browserSupportsCssAnimations()) return; | |||
|
|
|||
| it("should silently quit the animation and not throw when an element is not attached to a parent during preparation", | |||
There was a problem hiding this comment.
when an element has no parent removes the potential confusion of a double negative.
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
…n animated This fix ensures that both `$animateCss` and `$animate` swallow the error when an animation takes place in the sitation that the element is removed from the parent element sometime before or during the preparation stages of the animation. Closes angular#11975 Closes angular#12338
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix ensures that for both
$animateCssand$animatecapture the errorwhen an animation takes place where the element is removed from the
parent element sometime before or during the preparation stages of the
animation.
Closes #11975