This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($location): don't crash if navigating outside the app base #12361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -601,35 +601,35 @@ describe('$location', function() { | |||
|
|
|||
|
|
|||
| it('should return decoded characters for search specified in URL', function() { | |||
| var locationUrl = new LocationHtml5Url('http://host.com/'); | |||
| var locationUrl = new LocationHtml5Url('http://host.com/', 'http://host.com/', 'http://host.com/'); | |||
There was a problem hiding this comment.
Is the basePrefix really needed here ?
There was a problem hiding this comment.
Oops. No that was a bit of over zealous cutting and pasting :-)
petebacondarwin
force-pushed
the
issue-11667
branch
from
c22ddef
to
90126c6
Compare
Previously, if you navigate outside of the Angular application, say be clicking the back button, the $location service would try to handle the url change and error due to the URL not being valid for the application. This fixes that issue by ensuring that a reload happens when you navigate to a URL that is not within the application. Closes angular#11667
|
Yes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #11667