This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
docs($compile): add docs for bindToController with object hash #13681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narretz
force-pushed
the
fix-compile-bindtocontroller
branch
from
1bb2564
to
cf6861a
Compare
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Jan 5, 2016
Closes angular#13228 Closes angular#13625 Closes angular#13658 Closes angular#13681
|
We can add the bit about bound properties being available in a later commit. This particular PR LGTM right now. |
| * When an isolate scope is used for a component (see above), and `controllerAs` is used, `bindToController: true` will | ||
| * This property can be used to bind scope properties directly to the controller. It can be either | ||
| * `true` or an object hash with the same format as the `scope` property. Additionally, | ||
| * `controllerAs` must be used for it to work. |
There was a problem hiding this comment.
This makes it sound like the controllerAs property must be used (which is not the case).
To avoid confusion, I would re-phrase this to make it clear that a controller alias must be specified (either using controllerAs or controller: '... as ...').
Closes angular#13228 Closes angular#13625 Closes angular#13658 Closes angular#13681
Narretz
force-pushed
the
fix-compile-bindtocontroller
branch
from
cf6861a
to
c1e140a
Compare
Narretz
added a commit
that referenced
this pull request
Jan 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13228
Closes #13625