This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngMock): add sharedInjector() to angular.mock.module #14093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll review this later this week. Thanks |
| * ## Example | ||
| * | ||
| * Typically beforeAll is used to make many assertions about a single operation. This can | ||
| * cut down test run-tims, and produce focussed tests with a single assertion. |
|
@timruffles - nice one Tim! A couple of minor documentation points to deal with but it seems good to me. I think it is also worth updating the testing guide with this new feature (https://docs.angularjs.org/guide/unit-testing) |
timruffles
force-pushed
the
sharedInjectorBeforeAll
branch
3 times, most recently
from
b7e754a
to
8b44322
Compare
|
@petebacondarwin thanks for reviewing. Have updated docs as per your suggestions, and added a section to guide. The fiddles are also updated. |
|
Can you run |
timruffles
force-pushed
the
sharedInjectorBeforeAll
branch
from
8b44322
to
ca47210
Compare
Allow to opt-in to using a shared injector within a context. This allows hooks to be used in Jasmine 2.x.x/Mocha
timruffles
force-pushed
the
sharedInjectorBeforeAll
branch
from
ca47210
to
d9d56e9
Compare
|
@petebacondarwin Yup, fixed! Sorry about that. |
|
Just ran into this bug today and am delighted to see the fix is in. Thanks @timruffles ! 👍 |
|
@petebacondarwin let me know if there's anything else you like me to do on this! |
|
No problem. I'll deal with it today |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to opt-in to using a shared injector within a
describe()context, viaangular.mock.module.sharedInjector().This enables Jasmine 2.x/mocha's
beforeAll()/before()hooks to be used with Angular, fixing issue #10238 as previously discussed.Beyond the tests added to
angular-mocksSpec.js, I've also created JSFiddles with the new behaviour working alongside:The verification tests above contain tests suggested by @lgalfaso. cc/@petebacondarwin. The unit tests added contain a little test framework stub, as it was nigh on impossible to test this feature without interference from the rest of the Angular test machinery. Testing inception!