Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(formatNumber): handle small numbers correctly different gSize and… #14290

Closed

Conversation

owencraig
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug Fix

What is the current behavior? (You can also link to an open issue here)
#14289

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:

… lgSize

By using >= when comparing the number length to the lgSize we'll provide
the correct value when formatting numbers with differing lgSize and gSize

Closes #14289

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

… lgSize

By using >= when comparing the number length to the lgSize we'll provide
the correct value when formatting numbers with differing lgSize and gSize

Closes angular#14289
@owencraig owencraig force-pushed the fix-number-group-size-calculation branch from 13de517 to aa43cba Compare March 21, 2016 19:42
@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak
Copy link
Member

gkalpak commented Mar 21, 2016

LGTM

@gkalpak gkalpak closed this in 4202d8a Mar 21, 2016
gkalpak pushed a commit that referenced this pull request Mar 21, 2016
…gSize`

By using `>=` when comparing the number length to `lgSize`, we'll provide the correct value, when
formatting numbers with different `lgSize` than `gSize`.

Fixes #14289

Closes #14290
gkalpak pushed a commit that referenced this pull request Mar 21, 2016
…gSize`

By using `>=` when comparing the number length to `lgSize`, we'll provide the correct value, when
formatting numbers with different `lgSize` than `gSize`.

Fixes #14289

Closes #14290
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

formatNumber doesn't handle short numbers correctly in some locales
3 participants