This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
refactor(*): faster check for a string starting with a substring #14660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @spamdaemon for the original PR to make this improvement. In naive tests on Chrome I got the following results: ``` Matches Misses indexOf 33ms 1494ms lastIndexOf 11ms 11ms ``` Closes angular#3711
|
This is mostly to trigger Travis |
|
Landed as a4e4fee |
| @@ -909,7 +912,7 @@ function $LocationProvider() { | |||
| // update $location when $browser url changes | |||
| $browser.onUrlChange(function(newUrl, newState) { | |||
|
|
|||
| if (isUndefined(beginsWith(appBaseNoFile, newUrl))) { | |||
| if (isUndefined(stripBaseUrl(appBaseNoFile, newUrl))) { | |||
There was a problem hiding this comment.
Better
if (!startsWith(...)) {
?
There was a problem hiding this comment.
That would be good. Easy PR for you @lgalfaso :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @spamdaemon for the original PR (#3711) to make this improvement.
In naive tests on Chrome I got the following results: