Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Test on Safari 10 #15717

Closed
wants to merge 4 commits into from
Closed

Test on Safari 10 #15717

wants to merge 4 commits into from

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Feb 16, 2017

No description provided.

@Narretz
Copy link
Contributor Author

Narretz commented Mar 8, 2017

This is the test that fails:

it('should update thrown Error stack trace with inject call location', function() {
try {
throwErrorFromInjectCallback();
} catch (e) {
expect(e.stack).toMatch('testCaller');
}
});

In Safari 10.0.1, this test fails if the test file uses "use strict". Maybe this was fixed in 10.3?
This also fails on my iPhone 5s with ios 10.2.1.

Here's a plunkr to test: http://plnkr.co/edit/GD0CeGnzuYa1NHIEcj65?p=preview

@Narretz Narretz changed the title Test update Test on Safari 10 Apr 24, 2017
@Narretz
Copy link
Contributor Author

Narretz commented Jun 29, 2017

Safari 10 fails here:

  ngMock

    jasmine module and inject

      inject

        error stack trace when called outside of spec context

          on browsers supporting stack traces

            ✗ should update thrown Error stack trace with inject call location

	Expected 'test/ngMock/angular-mocksSpec.js:1011:28

	WorkFn@src/ngMock/angular-mocks.js:3159:26

	test/ngMock/angular-mocksSpec.js:1020:45

	attemptSync@node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1950:28

	run@node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1938:20

Narretz added a commit to Narretz/angular.js that referenced this pull request Oct 18, 2017
Previously, we used fixed versions that became outdated quickly for
FF and Chrome.

Safari currently still has failures, see
angular#15717
Narretz added a commit that referenced this pull request Oct 18, 2017
Previously, we used fixed versions that became outdated quickly for
FF and Chrome.

Safari 10/11 is not included because during the latest test there were 
failures, see #15717

Jasmine is fixed to 2.5.2 because 2.6.0+ is not compatible with the suite:
#15927 (comment)

Closes #15927
Narretz added a commit that referenced this pull request Oct 19, 2017
Previously, we used fixed versions that became outdated quickly for
FF and Chrome.

Safari 10/11 is not included because during the latest test there were 
failures, see #15717

Jasmine is fixed to 2.5.2 because 2.6.0+ is not compatible with the suite:
#15927 (comment)

Closes #15927
@Narretz Narretz modified the milestones: Purgatory, 1.6.x Nov 30, 2017
@Narretz
Copy link
Contributor Author

Narretz commented Jan 13, 2018

Added on master

@Narretz Narretz closed this Jan 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants