Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Replace:false in directive doesn't "append" as documented #2433

Closed
wants to merge 1 commit into from

Conversation

JakobJingleheimer
Copy link

According to the documentation:

replace - if set to true then the template will replace the current element, rather than append the template to the element.

As identified by #2235, the documented behaviour does not match the actual current behaviour.

…urrently replaces content instead of appending new content; now appends new content
@petebacondarwin
Copy link
Member

Hi @jshado1 - Thanks for submitting this pull request. Unfortunately there are a number of problems.

It is failing numerous tests: see https://travis-ci.org/angular/angular.js/builds/6431249.
It would also need to have new unit tests to demonstrate the issue it is solving.
We also need you to sign the CLA and to commit message would need to be fixed up.

At the moment it is not in a state to merge. Can you fix this and provide a new PR instead?

@JakobJingleheimer
Copy link
Author

@petebacondarwin I submitted the CLA.

Hoping to discuss proposed changes in the issue I opened for this: #2235

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants