This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(angular): Allow widgets to be styled in IE8 and below #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made all changes as above. Added issue-584.html to this pull request. |
|
Btw, why did you decided not to add unit test for this ? Any problems with the approach we discussed ? |
|
As per our conversation, added the check for "@" in the element name. Also, fixed typo (issue-352.html -> issue-584.html). |
| */ | ||
| function shivForIE(elementName) { | ||
| elementName = lowercase(elementName); | ||
| if (msie < 9 && element.indexOf('@') == -1) |
There was a problem hiding this comment.
this should be elementName.charAt(0) !== '@'
I'll fix that during squash
|
one small issue. otherwise LGTM. I'll fix it and squash it. |
|
landed as 163c799 thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #584