Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix one build warning in minall #7146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khasinski
Copy link

Request Type: bug

How to reproduce: build with grunt, warning shows in minall

Component(s): scope

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

There are several more issues like this, but I'm not sure if I know the right way to fix them.

Other Comments:

Used code from cironunes/angular.js, slightly modified (Firefox should be abbreviated Fx, exception variable should not be reassigned).

…is not a minErr instance.")

Used code from cironunes/angular.js, slightly modified (Firefox should be abbreviated Fx, exception variable should not be reassigned).
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7146)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@khasinski
Copy link
Author

I don't have Safari or IE to test whether the build is broken by this commit or there was an actual timeout for some builder.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@khasinski
Copy link
Author

Already signed as Krzysztof Hasiński.

@khasinski
Copy link
Author

It should be signed but somehow it's still not signed. Does mary-poppins check CLA regularly?

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants