fix one build warning in minall
#7146
base: master
Are you sure you want to change the base?
Conversation
…is not a minErr instance.") Used code from cironunes/angular.js, slightly modified (Firefox should be abbreviated Fx, exception variable should not be reassigned).
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
I don't have Safari or IE to test whether the build is broken by this commit or there was an actual timeout for some builder. |
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
Already signed as Krzysztof Hasiński. |
It should be signed but somehow it's still not signed. Does mary-poppins check CLA regularly? |
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
e8dc429
to
e83fab9
Compare
4dd5a20
to
998c61c
Compare
Request Type: bug
How to reproduce: build with
grunt
, warning shows inminall
Component(s): scope
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
There are several more issues like this, but I'm not sure if I know the right way to fix them.
Other Comments:
Used code from cironunes/angular.js, slightly modified (Firefox should be abbreviated Fx, exception variable should not be reassigned).