New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ngAria): Announce ngMessages with aria-live #9834

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@marcysutton
Member

marcysutton commented Oct 29, 2014

To be accessible, error messages shown with ngMessages should be read aloud in a screen reader. This can be easily accomplished by adding aria-live="assertive" to the ngMessages directive via ngAria.

Proof of concept in this Plunkr: http://plnkr.co/edit/6iFNWiSiRWz9y871v7oq

@mary-poppins mary-poppins added cla: yes and removed cla: no labels Oct 29, 2014

@Narretz Narretz added this to the Backlog milestone Nov 2, 2014

@matsko

This comment has been minimized.

Show comment
Hide comment
@matsko

matsko Nov 3, 2014

Member

@marcysutton what do you think?

Member

matsko commented Nov 3, 2014

@marcysutton what do you think?

@marcysutton

This comment has been minimized.

Show comment
Hide comment
@marcysutton

marcysutton Nov 3, 2014

Member

@matsko I'm not sure why this got added to the backlog...it's such an easy win, and it has test coverage. Does it need benchmarks or something?

Member

marcysutton commented Nov 3, 2014

@matsko I'm not sure why this got added to the backlog...it's such an easy win, and it has test coverage. Does it need benchmarks or something?

@kentcdodds

This comment has been minimized.

Show comment
Hide comment
@kentcdodds
Member

kentcdodds commented Nov 5, 2014

+1

@matsko

This comment has been minimized.

Show comment
Hide comment
@matsko

matsko Nov 5, 2014

Member

@marcysutton not sure who triaged this one, but if you're good to take it over then go for it :)

Member

matsko commented Nov 5, 2014

@marcysutton not sure who triaged this one, but if you're good to take it over then go for it :)

@marcysutton

This comment has been minimized.

Show comment
Hide comment
@marcysutton

marcysutton Nov 5, 2014

Member

@matsko I don't think I have Collaborator rights on this repo, only Angular Material. Is there someone else who can review and merge it?

Member

marcysutton commented Nov 5, 2014

@matsko I don't think I have Collaborator rights on this repo, only Angular Material. Is there someone else who can review and merge it?

@caitp

This comment has been minimized.

Show comment
Hide comment
@caitp

caitp Nov 5, 2014

Contributor

I'll take a look

Contributor

caitp commented Nov 5, 2014

I'll take a look

@caitp

This comment has been minimized.

Show comment
Hide comment
@caitp

caitp Nov 5, 2014

Contributor

The proof of concept works for me (it's extremely annoying when typing in the field though!), that's pretty cool.

I'll land it.

Contributor

caitp commented Nov 5, 2014

The proof of concept works for me (it's extremely annoying when typing in the field though!), that's pretty cool.

I'll land it.

@caitp caitp closed this in 187e431 Nov 5, 2014

@marcysutton

This comment has been minimized.

Show comment
Hide comment
@marcysutton

marcysutton Nov 5, 2014

Member

Hmm, it read at an okay frequency when I made the demo. We could always change it to polite if assertive proves to be rude. :)

Member

marcysutton commented Nov 5, 2014

Hmm, it read at an okay frequency when I made the demo. We could always change it to polite if assertive proves to be rude. :)

@caitp

This comment has been minimized.

Show comment
Hide comment
@caitp

caitp Nov 5, 2014

Contributor

the tone actually sounds okay, it's just the way it continuously repeats numbers you type in the field. I'm sure it would be less annoying if I couldn't see what I typed, though.

Contributor

caitp commented Nov 5, 2014

the tone actually sounds okay, it's just the way it continuously repeats numbers you type in the field. I'm sure it would be less annoying if I couldn't see what I typed, though.

@realityking

This comment has been minimized.

Show comment
Hide comment
@realityking

realityking Nov 5, 2014

Contributor

polite vs. assertive is not about the tone but whether the user should be interrupted (assertive) or to wait until the user is idle (polite).

I guess it depends a bit on how validation messages are used. We only show them after the first blur event or after the first attempt to submit, assertive is probably fine in this case. If the message is shown after the first user entry it might be very annoying.

Contributor

realityking commented Nov 5, 2014

polite vs. assertive is not about the tone but whether the user should be interrupted (assertive) or to wait until the user is idle (polite).

I guess it depends a bit on how validation messages are used. We only show them after the first blur event or after the first attempt to submit, assertive is probably fine in this case. If the message is shown after the first user entry it might be very annoying.

@caitp

This comment has been minimized.

Show comment
Hide comment
@caitp

caitp Nov 5, 2014

Contributor

TIL, thanks! (however, I'm talking about the reading of the value in the input field, not the reading of the messages --- those sounded great on my mac with VoiceOver. The reading of the value got a bit crazy)

Contributor

caitp commented Nov 5, 2014

TIL, thanks! (however, I'm talking about the reading of the value in the input field, not the reading of the messages --- those sounded great on my mac with VoiceOver. The reading of the value got a bit crazy)

@joe-watkins

This comment has been minimized.

Show comment
Hide comment
@joe-watkins

joe-watkins Dec 8, 2014

I'm wondering if there could be a way to allow for the author to choose Polite or Assertive rather than hardcode one or the other into ngAria?

Assertive interrupts everything that is being spoken.. and for form validation, or other use cases for that matter, could prove to be disorientating for some end users.

joe-watkins commented Dec 8, 2014

I'm wondering if there could be a way to allow for the author to choose Polite or Assertive rather than hardcode one or the other into ngAria?

Assertive interrupts everything that is being spoken.. and for form validation, or other use cases for that matter, could prove to be disorientating for some end users.

@marcysutton

This comment has been minimized.

Show comment
Hide comment
@marcysutton

marcysutton Dec 8, 2014

Member

We can totally do that! It probably should have been configurable from the start, but that's an easy change.

Member

marcysutton commented Dec 8, 2014

We can totally do that! It probably should have been configurable from the start, but that's an easy change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment