Skip to content

Commit

Permalink
ci: remove *.bazel from dev-infra ownership (#41382)
Browse files Browse the repository at this point in the history
Historically all .bazel files were owned by dev-infra to assist in ensuring that
consistency was maintained in how rules were being used.  As this now has reached
a point of maturity in the repository where the check is mostly a rubber stamping,
this requirement can be removed.  Notably this is different than the requirement
of dev-infra approval for .bzl files as these contain the implementation of macros
rather than just the usage.

PR Close #41382
  • Loading branch information
josephperrott authored and TeriGlover committed Apr 5, 2021
1 parent c3ea7dd commit 05f7f1c
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions .pullapprove.yml
Expand Up @@ -1166,7 +1166,7 @@ groups:
conditions:
- *can-be-global-approved
- >
contains_any_globs(files.exclude("packages/compiler-cli/**/BUILD.bazel"), [
contains_any_globs(files, [
'*',
'.circleci/**',
'.devcontainer/**',
Expand Down Expand Up @@ -1203,8 +1203,7 @@ groups:
'tools/utils/**',
'tools/yarn/**',
'tools/*',
'**/*.bzl',
'**/*.bazel'
'**/*.bzl'
])
reviewers:
users:
Expand Down

0 comments on commit 05f7f1c

Please sign in to comment.