fix(compiler): properly report missing DI tokens

Fixes #8245
angular · Jun 9, 2016 · 16caa5b · 16caa5b
1 parent e213939
commit 16caa5b
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/modules/@angular/compiler/src/metadata_resolver.ts b/modules/@angular/compiler/src/metadata_resolver.ts
@@ -260,11 +260,12 @@ export class CompileMetadataResolver {
 
   getDependenciesMetadata(typeOrFunc: Type | Function,
                           dependencies: any[]): cpl.CompileDiDependencyMetadata[] {
+    let hasUnknownDeps = false;
     let params = isPresent(dependencies) ? dependencies : this._reflector.parameters(typeOrFunc);
     if (isBlank(params)) {
       params = [];
     }
-    return params.map((param) => {
+    let dependenciesMetadata: cpl.CompileDiDependencyMetadata[] = params.map((param) => {
       if (isBlank(param)) {
         return null;
       }
@@ -306,6 +307,7 @@ export class CompileMetadataResolver {
         token = param;
       }
       if (isBlank(token)) {
+        hasUnknownDeps = true;
         return null;
       }
       return new cpl.CompileDiDependencyMetadata({
@@ -320,6 +322,15 @@ export class CompileMetadataResolver {
       });
 
     });
+
+    if (hasUnknownDeps) {
+      let depsTokens = dependenciesMetadata.map((dep) => {
+        return dep ? stringify(dep.token) : '?';
+      }).join(', ');
+      throw new BaseException(`Can't resolve all parameters for ${stringify(typeOrFunc)}: (${depsTokens}).`);
+    }
+
+    return dependenciesMetadata;
   }
 
   getTokenMetadata(token: any): cpl.CompileTokenMetadata {

diff --git a/modules/@angular/compiler/test/metadata_resolver_spec.ts b/modules/@angular/compiler/test/metadata_resolver_spec.ts
@@ -78,6 +78,14 @@ export function main() {
                  .toThrowError(`Expected 'styles' to be an array of strings.`);
            }
          }));
+
+      it('should throw with descriptive error message when provider token can not be resolved',
+         inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => {
+           if (!IS_DART) {
+             expect(() => resolver.getDirectiveMetadata(MyBrokenComp1))
+                 .toThrowError(`Can't resolve all parameters for MyBrokenComp1: (?).`);
+           }
+         }));
     });
 
     describe('getViewDirectivesMetadata', () => {
@@ -148,3 +156,11 @@ class ComponentWithEverything implements OnChanges,
   ngAfterViewInit(): void {}
   ngAfterViewChecked(): void {}
 }
+
+interface NonExisting {
+}
+
+@Component({selector: 'my-broken-comp', template: ''})
+class MyBrokenComp1 {
+  constructor(public dependency: NonExisting) {}
+}