refactor(platform-browser): cleanup references to dart (#49858)

The repo doesn't support dart anymore, we can reduce the references to it . PR Close #49858
angular · Apr 18, 2023 · 1816c89 · 1816c89
1 parent ff0d23d
commit 1816c89
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/packages/platform-browser-dynamic/test/resource_loader/resource_loader_impl_spec.ts b/packages/platform-browser-dynamic/test/resource_loader/resource_loader_impl_spec.ts
@@ -12,12 +12,6 @@ if (isBrowser) {
   describe('ResourceLoaderImpl', () => {
     let resourceLoader: ResourceLoaderImpl;
 
-    // TODO(juliemr): This file currently won't work with dart unit tests run using
-    // exclusive it or describe (iit or ddescribe). This is because when
-    // pub run test is executed against this specific file the relative paths
-    // will be relative to here, so url200 should look like
-    // static_assets/200.html.
-    // We currently have no way of detecting this.
     const url200 = '/base/angular/packages/platform-browser/test/browser/static_assets/200.html';
     const url404 = '/bad/path/404.html';
 

diff --git a/packages/platform-browser/src/browser/browser_adapter.ts b/packages/platform-browser/src/browser/browser_adapter.ts
@@ -23,11 +23,9 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter {
   }
 
   override onAndCancel(el: Node, evt: any, listener: any): Function {
-    el.addEventListener(evt, listener, false);
-    // Needed to follow Dart's subscription semantic, until fix of
-    // https://code.google.com/p/dart/issues/detail?id=17406
+    el.addEventListener(evt, listener);
     return () => {
-      el.removeEventListener(evt, listener, false);
+      el.removeEventListener(evt, listener);
     };
   }
   override dispatchEvent(el: Node, evt: any) {