fixup! refactor(ivy): Intruduce LFrame to store global instruction in…

…formation Co-Authored-By: Kara <kara@users.noreply.github.com>
angular · Oct 24, 2019 · 188c7b7 · 188c7b7
1 parent 98b8779
commit 188c7b7
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 1 deletion.
diff --git a/packages/core/src/render3/state.ts b/packages/core/src/render3/state.ts
@@ -462,7 +462,7 @@ export function enterDI(newView: LView, tNode: TNode) {
   newLFrame.previousOrParentTNode = tNode !;
   newLFrame.lView = newView;
   if (ngDevMode) {
-    // reseting for safety in dev mode only.
+    // resetting for safety in dev mode only.
     newLFrame.isParent = DEV_MODE_VALUE;
     newLFrame.selectedIndex = DEV_MODE_VALUE;
     newLFrame.contextLView = DEV_MODE_VALUE;

diff --git a/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json b/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
@@ -155,6 +155,9 @@
   {
     "name": "addToViewTree"
   },
+  {
+    "name": "allocLFrame"
+  },
   {
     "name": "allocStylingMapArray"
   },
@@ -230,6 +233,9 @@
   {
     "name": "elementCreate"
   },
+  {
+    "name": "enterDI"
+  },
   {
     "name": "enterView"
   },
@@ -485,6 +491,9 @@
   {
     "name": "isStylingValueDefined"
   },
+  {
+    "name": "leaveDI"
+  },
   {
     "name": "leaveView"
   },

diff --git a/packages/core/test/bundling/hello_world/bundle.golden_symbols.json b/packages/core/test/bundling/hello_world/bundle.golden_symbols.json
@@ -134,6 +134,9 @@
   {
     "name": "addToViewTree"
   },
+  {
+    "name": "allocLFrame"
+  },
   {
     "name": "appendChild"
   },
@@ -191,6 +194,9 @@
   {
     "name": "domRendererFactory3"
   },
+  {
+    "name": "enterDI"
+  },
   {
     "name": "enterView"
   },
@@ -356,6 +362,9 @@
   {
     "name": "isRootView"
   },
+  {
+    "name": "leaveDI"
+  },
   {
     "name": "leaveView"
   },

diff --git a/packages/core/test/bundling/todo/bundle.golden_symbols.json b/packages/core/test/bundling/todo/bundle.golden_symbols.json
@@ -362,6 +362,9 @@
   {
     "name": "addToViewTree"
   },
+  {
+    "name": "allocLFrame"
+  },
   {
     "name": "allocStylingMapArray"
   },
@@ -530,6 +533,9 @@
   {
     "name": "elementPropertyInternal"
   },
+  {
+    "name": "enterDI"
+  },
   {
     "name": "enterView"
   },
@@ -983,6 +989,9 @@
   {
     "name": "iterateListLike"
   },
+  {
+    "name": "leaveDI"
+  },
   {
     "name": "leaveView"
   },