test: remove view-engine-only tests (#44218)

This commit removes most tests that were designated as only covering View
Engine code. It also removes tag filters from CI and local commands to run
tests.

In a few cases (such as with the packages/compiler tests), this tag was
improperly applied, and certain test cases have been added back running in
Ivy mode.

This commit also empties `@angular/compiler/testing` as it is no longer
necessary (this is safe since compiler packages are not public API). It can
be deleted in the future.

PR Close #44218

.circleci/config.yml

@@ -344,7 +344,7 @@ jobs:
           # See /tools/saucelabs/README.md for more info
           command: |
             yarn bazel run //tools/saucelabs:sauce_service_setup
-            TESTS=$(./node_modules/.bin/bazelisk query --output label '(kind(karma_web_test, ...) intersect attr("tags", "saucelabs", ...)) except attr("tags", "view-engine-only", ...) except attr("tags", "fixme-saucelabs", ...)')
+            TESTS=$(./node_modules/.bin/bazelisk query --output label '(kind(karma_web_test, ...) intersect attr("tags", "saucelabs", ...)) except attr("tags", "fixme-saucelabs", ...)')
             yarn bazel test --config=saucelabs ${TESTS}
             yarn bazel run //tools/saucelabs:sauce_service_stop
           no_output_timeout: 40m
@@ -723,11 +723,11 @@ jobs:
       - setup_win
       - run:
           name: Build all windows CI targets
-          command: bazel build --build_tag_filters=-view-engine-only //packages/compiler-cli/...
+          command: bazel build //packages/compiler-cli/...
           no_output_timeout: 15m
       - run:
           name: Test all windows CI targets
-          command: bazel test --test_tag_filters="-view-engine-only,-browser:chromium-local" //packages/compiler-cli/...
+          command: bazel test --test_tag_filters="-browser:chromium-local" //packages/compiler-cli/...
           no_output_timeout: 15m
 
 workflows:

package.json

@@ -24,10 +24,7 @@
     "/ ": "",
     "postinstall": "node scripts/webdriver-manager-update.js && node --preserve-symlinks --preserve-symlinks-main ./tools/postinstall-patches.js",
     "prepare": "husky install",
-    "test": "bazelisk test --build_tag_filters=-view-engine-only --test_tag_filters=-view-engine-only",
-    "test-view-engine-only": "bazelisk test --config=view-engine --build_tag_filters=view-engine-only --test_tag_filters=view-engine-only",
-    "test-ivy-aot": "echo \\`test-ivy-aot\\` no longer valid, use \\`yarn test\\` instead",
-    "test-non-ivy": "echo \\`test-ivy-aot\\` no longer valid, use \\`yarn test-view-engine-only\\` instead",
+    "test": "bazelisk test",
     "test-tsec": "bazelisk test //... --build_tag_filters=tsec --test_tag_filters=tsec",
     "lint": "yarn -s tslint && yarn -s ng-dev format changed --check",
     "tslint": "tslint -c tslint.json --project tsconfig-tslint.json",

packages/bazel/test/ng_package/BUILD.bazel

@@ -82,7 +82,6 @@ jasmine_node_test(
     # file is based on non-ivy output and therefore won't work for ngc and Ivy at the same time.
     # TODO: Update test to rely on Ivy partial compilation after View Engine's removal, update the
     # golden files as appropriate for the change in compilation.
-    tags = ["view-engine-only"],
     deps = ["@npm//diff"],
 )