fix(compiler): allow binding to autocomplete property on select and t…

…extarea elements (#40928) Updates the schema to allow binding to the `autocomplete` property of a `textarea` or `select`. Fixes #39490. PR Close #40928
angular · Mar 3, 2021 · 20fb638 · 20fb638
1 parent c675acd
commit 20fb638
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/compiler/src/schema/dom_element_schema_registry.ts b/packages/compiler/src/schema/dom_element_schema_registry.ts
@@ -140,7 +140,7 @@ const SCHEMA: string[] = [
   'progress^[HTMLElement]|#max,#value',
   'q,blockquote,cite^[HTMLElement]|',
   'script^[HTMLElement]|!async,charset,%crossOrigin,!defer,event,htmlFor,integrity,src,text,type',
-  'select^[HTMLElement]|!autofocus,!disabled,#length,!multiple,name,!required,#selectedIndex,#size,value',
+  'select^[HTMLElement]|autocomplete,!autofocus,!disabled,#length,!multiple,name,!required,#selectedIndex,#size,value',
   'shadow^[HTMLElement]|',
   'slot^[HTMLElement]|name',
   'source^[HTMLElement]|media,sizes,src,srcset,type',
@@ -153,7 +153,7 @@ const SCHEMA: string[] = [
   'tr^[HTMLElement]|align,bgColor,ch,chOff,vAlign',
   'tfoot,thead,tbody^[HTMLElement]|align,ch,chOff,vAlign',
   'template^[HTMLElement]|',
-  'textarea^[HTMLElement]|autocapitalize,!autofocus,#cols,defaultValue,dirName,!disabled,#maxLength,#minLength,name,placeholder,!readOnly,!required,#rows,selectionDirection,#selectionEnd,#selectionStart,value,wrap',
+  'textarea^[HTMLElement]|autocapitalize,autocomplete,!autofocus,#cols,defaultValue,dirName,!disabled,#maxLength,#minLength,name,placeholder,!readOnly,!required,#rows,selectionDirection,#selectionEnd,#selectionStart,value,wrap',
   'title^[HTMLElement]|text',
   'track^[HTMLElement]|!default,kind,label,src,srclang',
   'ul^[HTMLElement]|!compact,type',

diff --git a/packages/language-service/src/html_info.ts b/packages/language-service/src/html_info.ts
@@ -285,7 +285,7 @@ const SCHEMA: string[] = [
   'progress^[HTMLElement]|#max,#value',
   'q,blockquote,cite^[HTMLElement]|',
   'script^[HTMLElement]|!async,charset,%crossOrigin,!defer,event,htmlFor,integrity,src,text,type',
-  'select^[HTMLElement]|!autofocus,!disabled,#length,!multiple,name,!required,#selectedIndex,#size,value',
+  'select^[HTMLElement]|autocomplete,!autofocus,!disabled,#length,!multiple,name,!required,#selectedIndex,#size,value',
   'shadow^[HTMLElement]|',
   'slot^[HTMLElement]|name',
   'source^[HTMLElement]|media,sizes,src,srcset,type',
@@ -298,7 +298,7 @@ const SCHEMA: string[] = [
   'tr^[HTMLElement]|align,bgColor,ch,chOff,vAlign',
   'tfoot,thead,tbody^[HTMLElement]|align,ch,chOff,vAlign',
   'template^[HTMLElement]|',
-  'textarea^[HTMLElement]|autocapitalize,!autofocus,#cols,defaultValue,dirName,!disabled,#maxLength,#minLength,name,placeholder,!readOnly,!required,#rows,selectionDirection,#selectionEnd,#selectionStart,value,wrap',
+  'textarea^[HTMLElement]|autocapitalize,autocomplete,!autofocus,#cols,defaultValue,dirName,!disabled,#maxLength,#minLength,name,placeholder,!readOnly,!required,#rows,selectionDirection,#selectionEnd,#selectionStart,value,wrap',
   'title^[HTMLElement]|text',
   'track^[HTMLElement]|!default,kind,label,src,srclang',
   'ul^[HTMLElement]|!compact,type',