Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build: ensure zone.js typing test is hermetic (#54048)
Currently the ZoneJS typing tests executes outside of Bazel, as a legacy artifact of the monorepo merging (as it seems - not ideal at all). Looks like this test relies on its own node modules, that were NOT locked using a yarn lock file. This commit adds one, and specifically locks it to a `@types/node` version that does not include the most recent patch release (which seemingly introduced a breaking change) that causes issues with TypeScript's lib checking. Whenever we perform lock file maintenance in the future, we have the following options: - Consider disabling lib checking via `skipLibCheck` for this test. This may be acceptable. - Continue locking the node version, - Waiting for chokidar to comply with the new signature - Waiting for the breaking change to be rolled back. Culprit change: DefinitelyTyped/DefinitelyTyped#68300 PR Close #54048
- Loading branch information