Skip to content

Commit

Permalink
fix(router): Clear internal transition when navigation finalizes (#54261
Browse files Browse the repository at this point in the history
)

This commit fixes a small memory issue in the router where a destroyed
component instance would be retained.

fixes #54241

PR Close #54261
  • Loading branch information
atscott authored and thePunderWoman committed Feb 6, 2024
1 parent 2de7679 commit 238f2a8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/router/src/navigation_transition.ts
Expand Up @@ -688,6 +688,7 @@ export class NavigationTransitions {
// finalized.
if (this.currentNavigation?.id === overallTransitionState.id) {
this.currentNavigation = null;
this.currentTransition = null;
}
}),
catchError((e) => {
Expand Down

0 comments on commit 238f2a8

Please sign in to comment.