fixup: fix(core): WIP - support Attribute DI decorator in deps se…

…ction of a token
angular · May 13, 2020 · 279261b · 279261b
1 parent 7e37bd8
commit 279261b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 33 deletions.
diff --git a/packages/core/src/di/metadata.ts b/packages/core/src/di/metadata.ts
@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {makeParamDecorator} from '../util/decorators';
 import {ɵɵinjectAttribute} from '../render3/instructions/di';
+import {makeParamDecorator} from '../util/decorators';
 
 
 /**
@@ -283,6 +283,7 @@ export interface Attribute {
  * @Annotation
  * @publicApi
  */
-export const Attribute: AttributeDecorator =
-    makeParamDecorator('Attribute', (attributeName?: string) => ({attributeName,
-      __NG_ELEMENT_ID__: () => ɵɵinjectAttribute(attributeName!)}));
+export const Attribute: AttributeDecorator = makeParamDecorator(
+    'Attribute',
+    (attributeName?: string) =>
+        ({attributeName, __NG_ELEMENT_ID__: () => ɵɵinjectAttribute(attributeName!)}));
diff --git a/packages/core/test/acceptance/di_spec.ts b/packages/core/test/acceptance/di_spec.ts
@@ -1800,7 +1800,7 @@ describe('di', () => {
     });
   });
 
-  fdescribe('attribute tokens', () => {
+  describe('attribute tokens', () => {
     it('should be able to provide an attribute token', () => {
       const TOKEN = new InjectionToken<string>('Some token');
       function factory(token: string): string {
@@ -1830,34 +1830,6 @@ describe('di', () => {
       fixture.detectChanges();
       expect(fixture.componentInstance.myComp.token).toBe('token with factory');
     });
-
-    it('should be able to provide an attribute token through the ngModule decorator', () => {
-      @Injectable({
-        providedIn: 'root',
-        useFactory: (token: string) => new Service(token),
-        deps: [new Attribute('token')]
-      })
-      class Service {
-        constructor(public token: string) {}
-      }
-
-      @Component({
-        selector: 'my-comp',
-        template: '...',
-        providers: [{provide: 'token', useValue: 'component token'}]
-      })
-      class MyComp {
-        constructor(public service: Service) {}
-      }
-
-      TestBed.configureTestingModule(
-          {declarations: [MyComp], providers: [{provide: 'token', useValue: 'module token'}]});
-
-      const fixture = TestBed.createComponent(MyComp);
-      fixture.detectChanges();
-
-      expect(fixture.componentInstance.service.token).toBe('module token');
-    });
   });
 
   it('should not cause cyclic dependency if same token is requested in deps with @SkipSelf', () => {