feat(metadata): emit all methods

This is needed to detect lifecycle hooks.
angular · May 4, 2016 · 29700aa · 29700aa
1 parent 3229bf1
commit 29700aa
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 18 deletions.
diff --git a/tools/metadata/src/collector.ts b/tools/metadata/src/collector.ts
@@ -131,20 +131,18 @@ export class MetadataCollector {
                 hasParameterData = true;
               }
             }
-            if (methodDecorators || hasDecoratorData || hasParameterData) {
-              const data: MethodMetadata = {__symbolic: isConstructor ? "constructor" : "method"};
-              const name = isConstructor ? "__ctor__" : evaluator.nameOf(member.name);
-              if (methodDecorators) {
-                data.decorators = methodDecorators;
-              }
-              if (hasDecoratorData) {
-                data.parameterDecorators = parameterDecoratorData;
-              }
-              if (hasParameterData) {
-                (<ConstructorMetadata>data).parameters = parametersData;
-              }
-              recordMember(name, data);
+            const data: MethodMetadata = {__symbolic: isConstructor ? "constructor" : "method"};
+            const name = isConstructor ? "__ctor__" : evaluator.nameOf(member.name);
+            if (methodDecorators) {
+              data.decorators = methodDecorators;
+            }
+            if (hasDecoratorData) {
+              data.parameterDecorators = parameterDecoratorData;
+            }
+            if (hasParameterData) {
+              (<ConstructorMetadata>data).parameters = parametersData;
             }
+            recordMember(name, data);
             break;
           case ts.SyntaxKind.PropertyDeclaration:
           case ts.SyntaxKind.GetAccessor:

diff --git a/tools/metadata/test/collector.spec.ts b/tools/metadata/test/collector.spec.ts
@@ -146,7 +146,10 @@ describe('Collector', () => {
                 parameters:
                     [{__symbolic: 'reference', name: undefined, module: './hero.service'}]
               }
-            ]
+            ],
+            onSelect: [{__symbolic: 'method'}],
+            ngOnInit: [{__symbolic: 'method'}],
+            getHeroes: [{__symbolic: 'method'}]
           }
         }
       }
@@ -232,7 +235,7 @@ const FILES: Directory = {
       import HeroService from './hero.service';
       // thrown away
       import 'angular2/core';
-      
+
       @MyComponent({
         selector: 'my-app',
         template:` + "`" + `
@@ -336,23 +339,23 @@ const FILES: Directory = {
       export class CaseAny {
         constructor(param: any) {}
       }
-      
+
       @Injectable()
       export class GetProp {
         private _name: string;
         @Input('firstName') get name(): string {
           return this._name;
         }
       }
-      
+
       @Injectable()
       export class SetProp {
         private _name: string;
         @Input('firstName') set name(value: string) {
           this._name = value;
         }
       }
-      
+
       @Injectable()
       export class FullProp {
         private _name: string;