Skip to content

Commit

Permalink
ci: Add primitives groups to pullapprove (#53404)
Browse files Browse the repository at this point in the history
This adds the shared primitives reviewers groups and list of reviewers
to the pullapprove rules.

PR Close #53404
  • Loading branch information
thePunderWoman committed Apr 3, 2024
1 parent 45ae7a6 commit 2ff74dc
Show file tree
Hide file tree
Showing 2 changed files with 77 additions and 1 deletion.
77 changes: 76 additions & 1 deletion .pullapprove.yml
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ groups:
<<: *defaults
conditions:
- >
contains_any_globs(files.exclude("packages/core/schematics/*"), [
contains_any_globs(files.exclude("packages/core/schematics/*").exclude('packages/core/primitives/*'), [
'packages/core/**/{*,.*}',
'packages/examples/core/**/{*,.*}',
'packages/platform-browser/**/{*,.*}',
Expand Down Expand Up @@ -1321,6 +1321,81 @@ groups:
- jessicajaniuk
- josephperrott

# =========================================================
# Primitives
# =========================================================

# Angular team required reviews
primitives:
<<: *defaults
conditions:
- >
contains_any_globs(files, [
'packages/core/primitives/**/{*,.*}',
])
reviewers:
users:
- pkozlowski-opensource # Pawel Kozlowski
- alxhub # Alex Rickabaugh
- jessicajaniuk # Jessica Janiuk
- dylhunn # Dylan Hunn
- AndrewKushnir # Andrew Kushnir
- atscott # Andrew Scott
reviews:
required: 1
reviewed_for: required
labels:
pending: 'requires: TGP'
approved: 'requires: TGP'
rejected: 'requires: TGP'

# External team required reviews
primitives-shared:
<<: *defaults
conditions:
- >
contains_any_globs(files, [
'packages/core/primitives/**/{*,.*}',
])
reviewers:
users:
- csmick # Cameron Smick
- lannka # Hongfei Ding
- eduhmc # Eduardo Huerta-Mercado
- ehlemur # Edward Lesmes
- ellenyuan # Ellen Yuan
- jatraman # Jatin Ramanathan
- jesse-good # Jesse Costello-Good
- mturco # Matt Turco
- neonstalwart # Ben Hockey
- nicholasyu-google # Nicholas Yu
- rahatarmanahmed # Rahat Ahmed
- emspishak # Eric Spishak-Thomas
reviews:
required: 1
reviewed_for: required
labels:
pending: 'requires: TGP'
approved: 'requires: TGP'
rejected: 'requires: TGP'

# External team required reviews
primitives-jsaction:
<<: *defaults
conditions:
- >
contains_any_globs(files, [
'packages/core/primitives/jsaction/**/{*,.*}',
])
reviewers:
users:
- iteriani # Thomas Nguyen
- tbondwilkinson # Tom Wilkinson
- rahatarmanahmed # Rahat Ahmed
reviews:
required: 1
reviewed_for: required

####################################################################################
# Override managed result groups
#
Expand Down
1 change: 1 addition & 0 deletions packages/core/primitives/jsaction/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# TBD

0 comments on commit 2ff74dc

Please sign in to comment.