-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(core): only run
checkNoChanges
once per tick (#54074)
This change updates the `checkNoChanges` pass to only run once after both view refresh and `afterRender` hooks execute rather than both before and after the hooks. The original motivation was to specifically ensure that the application was in a "clean state" before running the `afterRender` hooks and ensure that `afterRender` hooks don't "fix" `ExpressionChanged...` errors. This, however, adds to the complexity and cost of running change detection in dev mode. Instead, the `checkNoChanges` pass runs once we have done all render-related work and want to ensure that the application state has been synced to the DOM (without additional changes). PR Close #54074
- Loading branch information
1 parent
ecaf7ce
commit 33e5abd
Showing
2 changed files
with
6 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters