-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Also switch our CircleCI commands to just bazel build //... bazel test //... as this is easier to understand. Note, the reason this commit removes `firebase-tools` is: 1) firebase-tools has an optional dependency on https://www.npmjs.com/package/@google-cloud/functions-emulator 2) yarn's `--ignore-optional` doesn't work for transitive deps, so there's no way to yarn install without getting that functions-emulator package 3) functions-emulator has a transitive dep on `grpc` 4) the version of `grpc` we get has `BUILD` files and no `WORKSPACE` file so it always breaks `bazel build ...` It could be solved by any of: 1) remove firebase-tools - this is what I did 2) fix yarn so you can omit optional deps of a transitive dep 3) make functions-emulator depend transitively on a more recent `grpc` version 4) patch `grpc` after install by doing an `rm` command in our postinstall or something In its place we must install protobufjs. This is needed by the ngc-wrapped test, which needs jasmine as well as bazel's worker mode dependencies, and therefore cannot simply rely on node_modules = "@build_bazel_rules_typescript_tsc_wrapped_deps//:node_modules"
- Loading branch information
Showing
5 changed files
with
97 additions
and
1,576 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.