Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
vlajos authored and wardbell committed Jun 22, 2017
1 parent 1fc0d05 commit 364d16d
Show file tree
Hide file tree
Showing 43 changed files with 51 additions and 53 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ describe(`nginx`, () => {

describe(`${host}/*`, () => {

it('should respond with 404 for unkown URLs (even if the resource exists)', done => {
it('should respond with 404 for unknown URLs (even if the resource exists)', done => {
['index.html', 'foo.js', 'foo/index.html'].forEach(relFilePath => {
const absFilePath = path.join(h.buildsDir, relFilePath);
h.writeFile(absFilePath, {content: `File: /${relFilePath}`});
Expand Down
2 changes: 1 addition & 1 deletion aio/aio-builds-setup/docs/overview--security-model.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ This section describes how each of the aforementioned sub-tasks is accomplished:

4. **Deploy the artifacts to the corresponding PR's directory.**

With the preceeding steps, we have verified that the uploaded artifacts have been uploaded by
With the preceding steps, we have verified that the uploaded artifacts have been uploaded by
Travis and correspond to a PR whose author is a member of a trusted team. Essentially, as long as
sub-tasks 1, 2 and 3 can be securely accomplished, it is possible to "project" the trust we have
in a team's members through the PR and Travis to the build artifacts.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { Hero } from './hero';
const HEROES = [
new Hero('Windstorm', 'Weather mastery'),
new Hero('Mr. Nice', 'Killing them with kindness'),
new Hero('Magneta', 'Manipulates metalic objects')
new Hero('Magneta', 'Manipulates metallic objects')
];

@Injectable()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ if (!/e2e/.test(location.search)) {
directives.push(CountdownLocalVarParentComponent);
directives.push(CountdownViewChildParentComponent);
} else {
// In e2e test use CUSTOM_ELEMENTS_SCHEMA to supress unknown element errors
// In e2e test use CUSTOM_ELEMENTS_SCHEMA to suppress unknown element errors
schemas.push(CUSTOM_ELEMENTS_SCHEMA);
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "Hierachical Dependency Injection",
"description": "Hierarchical Dependency Injection",
"basePath": "src/",
"files":[
"!**/*.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion aio/content/examples/pipes/e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe('Pipes', function () {
return resetEle.click();
})
.then(function() {
expect(flyingHeroesEle.count()).toEqual(2, 'reset should restore orginal flying heroes');
expect(flyingHeroesEle.count()).toEqual(2, 'reset should restore original flying heroes');
});
});

Expand Down
2 changes: 1 addition & 1 deletion aio/content/examples/testing/src/app/bag/bag.ts
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ export class InnerCompWithExternalTemplateComponent { }

@Component({
selector: 'bad-template-comp',
templateUrl: './non-existant.html'
templateUrl: './non-existent.html'
})
export class BadTemplateUrlComponent { }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ function heroModuleSetup() {
// #enddocregion route-no-id

// #docregion route-bad-id
describe('when navigate to non-existant hero id', () => {
describe('when navigate to non-existent hero id', () => {
beforeEach( async(() => {
activatedRoute.testParams = { id: 99999 };
createComponent();
Expand Down
2 changes: 1 addition & 1 deletion aio/content/guide/dependency-injection-in-action.md
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ You can limit the scope of an injected service to a *branch* of the application
by providing that service *at the sub-root component for that branch*.
This example shows how similar providing a service to a sub-root component is
to providing a service in the root `AppComponent`. The syntax is the same.
Here, the `HeroService` is availble to the `HeroesBaseComponent` because it is in the `providers` array:
Here, the `HeroService` is available to the `HeroesBaseComponent` because it is in the `providers` array:

<code-example path="dependency-injection-in-action/src/app/sorted-heroes.component.ts" region="injection" title="src/app/sorted-heroes.component.ts (HeroesBaseComponent excerpt)">

Expand Down
2 changes: 1 addition & 1 deletion aio/content/guide/displaying-data.md
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ Read more about `ngIf` and `*` in the [ngIf section](guide/template-syntax#ngIf)


The template expression inside the double quotes,
`*ngIf="heros.length > 3"`, looks and behaves much like TypeScript.
`*ngIf="heroes.length > 3"`, looks and behaves much like TypeScript.
When the component's list of heroes has more than three items, Angular adds the paragraph
to the DOM and the message appears. If there are three or fewer items, Angular omits the
paragraph, so no message appears. For more information,
Expand Down
2 changes: 0 additions & 2 deletions aio/content/guide/form-validation.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,8 @@ on custom validation directives.

* Binding to the new `formErrors.name` property is sufficient to display all name validation error messages.


{@a component-class}


### Component class
The original component code for Template 1 stayed the same; however,
Template 2 requires some changes in the component. This section covers the code
Expand Down
4 changes: 2 additions & 2 deletions aio/content/guide/reactive-forms.md
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ If you do not bind the value, the select shows the first option from the data mo
The component _class_ defines control properties without regard for their representation in the template.
You define the `state`, `power`, and `sidekick` controls the same way you defined the `name` control.
You tie these controls to the template HTML elements in the same way,
specifiying the `FormControl` name with the `formControlName` directive.
specifying the `FormControl` name with the `formControlName` directive.

See the API reference for more information about
[radio buttons](api/forms/RadioControlValueAccessor "API: RadioControlValueAccessor"),
Expand Down Expand Up @@ -1220,7 +1220,7 @@ Place a button on the form so the user can add a new _secret lair_ and wire it t

Be sure to **add the `type="button"` attribute**.
In fact, you should always specify a button's `type`.
Without an explict type, the button type defaults to "submit".
Without an explicit type, the button type defaults to "submit".
When you later add a _form submit_ action, every "submit" button triggers the submit action which
might do something like save the current changes.
You do not want to save changes when the user clicks the _Add a Secret Lair_ button.
Expand Down
2 changes: 1 addition & 1 deletion aio/content/guide/setup-systemjs-anatomy.md
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ If you do, this page can help you understand their purpose.


A list of files that you can delete if you want to purge your setup of the
original QuickStart Seed testing and git maintainence artifacts.
original QuickStart Seed testing and git maintenance artifacts.
See instructions in the optional
[_Deleting non-essential files_](guide/setup#non-essential "Setup: Deleting non-essential files") section.
*Do this only in the beginning to avoid accidentally deleting your own tests and git setup!*
Expand Down
4 changes: 2 additions & 2 deletions aio/content/guide/styleguide.md
Original file line number Diff line number Diff line change
Expand Up @@ -3127,7 +3127,7 @@ that may need features from another common module; for example,



**Why?** A lazy loaded feature module that imports that shared module will make its own copy of the service and likely have undesireable results.
**Why?** A lazy loaded feature module that imports that shared module will make its own copy of the service and likely have undesirable results.


</div>
Expand Down Expand Up @@ -3377,7 +3377,7 @@ Yet they're too big and messy to leave loose in the root folder.



**Why?** A lazily loaded feature module that directly imports the `CoreModule` will make its own copy of services and likely have undesireable results.
**Why?** A lazily loaded feature module that directly imports the `CoreModule` will make its own copy of services and likely have undesirable results.


</div>
Expand Down
2 changes: 1 addition & 1 deletion aio/content/guide/template-syntax.md
Original file line number Diff line number Diff line change
Expand Up @@ -1371,7 +1371,7 @@ _This_ section is an introduction to the common structural directives:
### NgIf

You can add or remove an element from the DOM by applying an `NgIf` directive to
that element (called the _host elment_).
that element (called the _host element_).
Bind the directive to a condition expression like `isActive` in this example.

<code-example path="template-syntax/src/app/app.component.html" region="NgIf-1" title="src/app/app.component.html" linenums="false">
Expand Down
2 changes: 1 addition & 1 deletion aio/content/guide/ts-to-js.md
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ by calling the `@Inject()` decorator with the injection token.
In the following example, the token is the string `'heroName'`.

The other JavaScript dialects add a `parameters` array to the class constructor function.
Each item constrains a new instance of `Inject`:
Each item contains a new instance of `Inject`:

* _Plain ES6_&mdash;each item is a new instance of `Inject(token)` in a sub-array.
* _ES5_&mdash;simply list the string tokens.
Expand Down
2 changes: 1 addition & 1 deletion aio/src/assets/images/home/speed-performance.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion aio/src/styles/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Media queries
To use these, put this snippet in the approriate selector:
To use these, put this snippet in the appropriate selector:
@include bp(tiny) {
background-color: purple;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ describe('addNotYetDocumentedProperty', function() {
});


it('should not mark documents explicity tagged as `@noDescription`', function() {
it('should not mark documents explicitly tagged as `@noDescription`', function() {
var a, a1, a2, b, b1, b2, c, c1, c2;
var docs = [
a = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module.exports = function() {
if (newLines.length > 0) {
newLines.pop();
} else {
// wierd case - first expression in str is an @example
// weird case - first expression in str is an @example
// in this case the :marked appear above the str passed in,
// so we need to put 'something' into the markdown tag.
newLines.push(sp + '.'); // '.' is a dummy char
Expand Down
2 changes: 1 addition & 1 deletion docs/TOOLS.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ computing the changes being slow, or due to the act of applying those changes
to the UI. For your application to be performant it is important that the
process of computing changes is very fast. For best results it should be under
3 milliseconds in order to leave room for the application logic, the UI updates
and browser's rendering pipeline to fit withing the 16 millisecond frame
and browser's rendering pipeline to fit within the 16 millisecond frame
(assuming the 60 FPS target frame rate).

Change detection profiler repeatedly performs change detection without invoking
Expand Down
2 changes: 1 addition & 1 deletion integration/language_service_plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "language_service_plugin",
"version": "0.0.0",
"license": "MIT",
"decription": "Angular Langauge Service plugin integration test",
"decription": "Angular Language Service plugin integration test",
"dependencies": {
"@angular/animations": "file:../../dist/packages-dist/animations",
"@angular/common": "file:../../dist/packages-dist/common",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export function main() {
/Unable to listen on the animation trigger "myTrigger" because the provided event is undefined!/);
});

it('should retain event listeners and call them for sucessive animation state changes',
it('should retain event listeners and call them for successive animation state changes',
() => {
const engine = makeEngine();
const trig = trigger(
Expand Down Expand Up @@ -282,8 +282,8 @@ export function main() {
'* => *', [style({height: '0px'}), animate(1234, style({height: '100px'}))])
]));

// we do this so that the next transition has a starting value that isnt null
setProperty(element, engine, 'myTrigger', '123');
// we do this so that the next transition has a starting value that isn't null
engine.setProperty(element, 'myTrigger', '123');
engine.flush();

let capture: AnimationEvent = null !;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export class ChromeDriverExtension extends WebDriverExtension {
categories, name, ['benchmark'],
'BenchmarkInstrumentation::ImplThreadRenderingStats')) {
// TODO(goderbauer): Instead of BenchmarkInstrumentation::ImplThreadRenderingStats the
// following events should be used (if available) for more accurate measurments:
// following events should be used (if available) for more accurate measurements:
// 1st choice: vsync_before - ground truth on Android
// 2nd choice: BenchmarkInstrumentation::DisplayRenderingStats - available on systems with
// new surfaces framework (not broadly enabled yet)
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/directives/ng_if.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import {Directive, EmbeddedViewRef, Input, TemplateRef, ViewContainerRef} from '
* A common pattern is that we need to show a set of properties from the same object. If the
* object is undefined, then we have to use the safe-traversal-operator `?.` to guard against
* dereferencing a `null` value. This is especially the case when waiting on async data such as
* when using the `async` pipe as shown in folowing example:
* when using the `async` pipe as shown in following example:
*
* ```
* Hello {{ (userStream|async)?.last }}, {{ (userStream|async)?.first }}!
Expand Down
2 changes: 1 addition & 1 deletion packages/compiler/src/aot/summary_serializer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class ToJsonSerializer extends ValueTransformer {
__symbol: index,
name: symbol.name,
// We convert the source filenames tinto output filenames,
// as the generated summary file will be used when teh current
// as the generated summary file will be used when the current
// compilation unit is used as a library
filePath: this.summaryResolver.getLibraryFileName(symbol.filePath),
importAs: importAs
Expand Down
2 changes: 1 addition & 1 deletion packages/compiler/test/ml_parser/html_parser_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ export function main() {
expect((ast.rootNodes[0] as html.Element).attrs[0].valueSpan).toBeUndefined();
});

it('should report a value span for an attibute with a value', () => {
it('should report a value span for an attribute with a value', () => {
const ast = parser.parse('<div bar="12"></div>', 'TestComp');
const attr = (ast.rootNodes[0] as html.Element).attrs[0];
expect(attr.valueSpan !.start.offset).toEqual(9);
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/view/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export interface ViewHandleEventFn {
}

/**
* Bitmask for ViewDefintion.flags.
* Bitmask for ViewDefinition.flags.
*/
export const enum ViewFlags {
None = 0,
Expand Down
8 changes: 4 additions & 4 deletions packages/core/test/linker/regression_integration_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -242,14 +242,14 @@ function declareTests({useJit}: {useJit: boolean}) {
return MyComponent;
}
const HeroComponent = ComponentFactory('my-hero', 'my hero');
const VillianComponent = ComponentFactory('a-villian', 'a villian');
const VillainComponent = ComponentFactory('a-villain', 'a villain');
const MainComponent = ComponentFactory(
'my-app', 'I was saved by <my-hero></my-hero> from <a-villian></a-villian>.');
'my-app', 'I was saved by <my-hero></my-hero> from <a-villain></a-villain>.');

TestBed.configureTestingModule(
{declarations: [HeroComponent, VillianComponent, MainComponent]});
{declarations: [HeroComponent, VillainComponent, MainComponent]});
const fixture = TestBed.createComponent(MainComponent);
expect(fixture.nativeElement).toHaveText('I was saved by my hero from a villian.');
expect(fixture.nativeElement).toHaveText('I was saved by my hero from a villain.');
});

it('should allow to use the renderer outside of views', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/test/util/decorators_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export function main() {
});


it('should ensure that we dont accidently patch native objects', () => {
it('should ensure that we dont accidentally patch native objects', () => {
expect(() => {
(<Function>Class)({constructor: Object});
}).toThrowError('Can not use native Object as constructor');
Expand Down
2 changes: 1 addition & 1 deletion packages/core/test/view/provider_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export function main() {
.toThrowError('No provider for Dep!');
});

it('should inject from a parent elment in a parent view', () => {
it('should inject from a parent element in a parent view', () => {
createAndGetRootNodes(compViewDef([
elementDef(
NodeFlags.None, null !, null !, 1, 'div', null !, null !, null !, null !,
Expand Down
2 changes: 1 addition & 1 deletion packages/language-service/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export {

/**
* The information `LanguageService` needs from the `LanguageServiceHost` to describe the content of
* a template and the langauge context the template is in.
* a template and the language context the template is in.
*
* A host interface; see `LanguageSeriviceHost`.
*
Expand Down
2 changes: 1 addition & 1 deletion packages/language-service/test/language_service_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('service without angular', () => {
() => expect(() => ngService.getDiagnostics(fileName)).not.toThrow());
it('should not crash a completion',
() => expect(() => ngService.getCompletionsAt(fileName, position)).not.toThrow());
it('should not crash a get defintion',
it('should not crash a get definition',
() => expect(() => ngService.getDefinitionAt(fileName, position)).not.toThrow());
it('should not crash a hover', () => expect(() => ngService.getHoverAt(fileName, position)));
});
4 changes: 2 additions & 2 deletions packages/language-service/test/ts_plugin_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ describe('plugin', () => {
it('should reference the component',
() => { contains('app/parsing-cases.ts', 'test-comp-after-test', 'name'); });
// TODO: Enable when we have a flag that indicates the project targets the DOM
// it('should refernce the element if no component', () => {
// it('should reference the element if no component', () => {
// contains('app/parsing-cases.ts', 'test-comp-after-div', 'innerText');
// });
});
Expand All @@ -163,7 +163,7 @@ describe('plugin', () => {
'app/expression-cases.ts', 'myField',
'Identifier \'myField\' refers to a private member of the component');
});
it('should report numeric operator erros',
it('should report numeric operator errors',
() => { expectSemanticError('app/expression-cases.ts', 'mod', 'Expected a numeric type'); });
describe('in ngFor', () => {
function expectError(locationMarker: string, message: string) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class FancyService {
class ExternalTemplateComp {
}

@Component({selector: 'bad-template-comp', templateUrl: 'non-existant.html'})
@Component({selector: 'bad-template-comp', templateUrl: 'non-existent.html'})
class BadTemplateUrl {
}

Expand Down Expand Up @@ -110,7 +110,7 @@ export function main() {
() => { done.fail('Expected test to fail, but it did not'); },
(err: any) => {
expect(err.message)
.toEqual('Uncaught (in promise): Failed to load non-existant.html');
.toEqual('Uncaught (in promise): Failed to load non-existent.html');
done();
});
restoreJasmineIt();
Expand Down
2 changes: 1 addition & 1 deletion packages/platform-browser/src/security/html_sanitizer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ const HTML_ATTRS = tagSet(
'scope,scrolling,shape,size,sizes,span,srclang,start,summary,tabindex,target,title,translate,type,usemap,' +
'valign,value,vspace,width');

// NB: This currently conciously doesn't support SVG. SVG sanitization has had several security
// NB: This currently consciously doesn't support SVG. SVG sanitization has had several security
// issues in the past, so it seems safer to leave it out if possible. If support for binding SVG via
// innerHTML is required, SVG attributes should be added here.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export interface MessageBusSink {
* Sets up a new channel on the MessageBusSink.
* MUST be called before calling to on the channel.
* If runInZone is true the sink will buffer messages and send only once the zone exits.
* if runInZone is false the sink will send messages immediatly.
* if runInZone is false the sink will send messages immediately.
*/
initChannel(channel: string, runInZone: boolean): void;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export function main() {
}),
500);

it('should send messages immediatly when run outside the zone',
it('should send messages immediately when run outside the zone',
inject([AsyncTestCompleter, NgZone], (async: AsyncTestCompleter, zone: MockNgZone) => {
bus = createConnectedMessageBus();
setup(false, zone);
Expand Down

0 comments on commit 364d16d

Please sign in to comment.