refactor(compiler-cli): rename ExtendedTemplateChecker get diagnost…

…ics fucntion (#43134) Rename `getExtendedTemplateDiagnosticsForComponent` to `getDiagnosticsForComponent` since it's implied they are extended diagnostics. Refs #42966 PR Close #43134
angular · Aug 25, 2021 · 3ad527d · 3ad527d
1 parent b6ff762
commit 3ad527d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/packages/compiler-cli/src/ngtsc/annotations/src/component.ts b/packages/compiler-cli/src/ngtsc/annotations/src/component.ts
@@ -616,7 +616,7 @@ export class ComponentDecoratorHandler implements
   extendedTemplateCheck(
       component: ts.ClassDeclaration,
       extendedTemplateChecker: ExtendedTemplateChecker): ts.Diagnostic[] {
-    return extendedTemplateChecker.getExtendedTemplateDiagnosticsForComponent(component);
+    return extendedTemplateChecker.getDiagnosticsForComponent(component);
   }
 
   resolve(

diff --git a/packages/compiler-cli/src/ngtsc/typecheck/extended/api/extended_template_checker.ts b/packages/compiler-cli/src/ngtsc/typecheck/extended/api/extended_template_checker.ts
@@ -16,5 +16,5 @@ export interface ExtendedTemplateChecker {
   /**
    * Run `TemplateCheck`s for a component and return the generated `ts.Diagnostic`s.
    */
-  getExtendedTemplateDiagnosticsForComponent(component: ts.ClassDeclaration): TemplateDiagnostic[];
+  getDiagnosticsForComponent(component: ts.ClassDeclaration): TemplateDiagnostic[];
 }
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/extended/src/extended_template_checker.ts b/packages/compiler-cli/src/ngtsc/typecheck/extended/src/extended_template_checker.ts
@@ -18,7 +18,7 @@ export class ExtendedTemplateCheckerImpl implements ExtendedTemplateChecker {
       private readonly typeChecker: ts.TypeChecker,
       private readonly templateChecks: TemplateCheck<ErrorCode>[]) {}
 
-  getExtendedTemplateDiagnosticsForComponent(component: ts.ClassDeclaration): TemplateDiagnostic[] {
+  getDiagnosticsForComponent(component: ts.ClassDeclaration): TemplateDiagnostic[] {
     const template = this.templateTypeChecker.getTemplate(component);
     // Skip checks if component has no template. This can happen if the user writes a
     // `@Component()` but doesn't add the template, could happen in the language service

diff --git a/...piler-cli/src/ngtsc/typecheck/extended/test/template_checks/invalid_banana_in_box/spec.ts b/...piler-cli/src/ngtsc/typecheck/extended/test/template_checks/invalid_banana_in_box/spec.ts
@@ -30,7 +30,7 @@ runInEachFileSystem(() => {
       const component = getClass(sf, 'TestCmp');
       const extendedTemplateChecker = new ExtendedTemplateCheckerImpl(
           templateTypeChecker, program.getTypeChecker(), [new InvalidBananaInBoxCheck()]);
-      const diags = extendedTemplateChecker.getExtendedTemplateDiagnosticsForComponent(component);
+      const diags = extendedTemplateChecker.getDiagnosticsForComponent(component);
       expect(diags.length).toBe(1);
       expect(diags[0].category).toBe(ts.DiagnosticCategory.Warning);
       expect(diags[0].code).toBe(ngErrorCode(ErrorCode.INVALID_BANANA_IN_BOX));
@@ -50,7 +50,7 @@ runInEachFileSystem(() => {
       const component = getClass(sf, 'TestCmp');
       const extendedTemplateChecker = new ExtendedTemplateCheckerImpl(
           templateTypeChecker, program.getTypeChecker(), [new InvalidBananaInBoxCheck()]);
-      const diags = extendedTemplateChecker.getExtendedTemplateDiagnosticsForComponent(component);
+      const diags = extendedTemplateChecker.getDiagnosticsForComponent(component);
       expect(diags.length).toBe(0);
     });
 
@@ -68,8 +68,7 @@ runInEachFileSystem(() => {
          const component = getClass(sf, 'TestCmp');
          const extendedTemplateChecker = new ExtendedTemplateCheckerImpl(
              templateTypeChecker, program.getTypeChecker(), [new InvalidBananaInBoxCheck()]);
-         const diags =
-             extendedTemplateChecker.getExtendedTemplateDiagnosticsForComponent(component);
+         const diags = extendedTemplateChecker.getDiagnosticsForComponent(component);
          expect(diags.length).toBe(0);
        });
 
@@ -91,7 +90,7 @@ runInEachFileSystem(() => {
       const component = getClass(sf, 'TestCmp');
       const extendedTemplateChecker = new ExtendedTemplateCheckerImpl(
           templateTypeChecker, program.getTypeChecker(), [new InvalidBananaInBoxCheck()]);
-      const diags = extendedTemplateChecker.getExtendedTemplateDiagnosticsForComponent(component);
+      const diags = extendedTemplateChecker.getDiagnosticsForComponent(component);
       expect(diags.length).toBe(2);
       expect(diags[0].category).toBe(ts.DiagnosticCategory.Warning);
       expect(diags[0].code).toBe(ngErrorCode(ErrorCode.INVALID_BANANA_IN_BOX));