Skip to content

Commit

Permalink
build: use npx for setting firebase deploy targets in AIO preview (#4…
Browse files Browse the repository at this point in the history
…8346)

For the deploy job we still need to use the Firebase CLI to configure
the proper hosting deploy targets. See:
011ef66.

We don't have node modules installed in this job, and it would
also be overkill to install them for just using firebase here.

Since the action uses `npx firebase-tools` down the line anyway,
we can use it without any speed downsides.

PR Close #48346
  • Loading branch information
devversion committed Dec 4, 2022
1 parent 011ef66 commit 43e8f47
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/aio-preview-deploy.yml
Expand Up @@ -24,9 +24,11 @@ jobs:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # tag=v3

- name: Configure Firebase deploy target
working-directory: aio/
run: |
yarn --cwd aio firebase target:clear hosting aio
yarn --cwd aio firebase target:apply hosting aio ng-comp-dev
# We can use `npx` as the Firebase deploy actions uses it too.
npx -y firebase-tools@latest target:clear hosting aio
npx -y firebase-tools@latest target:apply hosting aio ng-comp-dev
- uses: angular/dev-infra/github-actions/deploy-previews/upload-artifacts-to-firebase@3bc93449e11b733260d0294305bf57240d7e0a81
with:
Expand Down

0 comments on commit 43e8f47

Please sign in to comment.