refactor(docs-infra): use tslint in aio's tools-lint script (#43010)

Instead of the deprecated tslint use eslint in the aio's tools-lint
script

PR Close #43010

aio/package.json

@@ -56,7 +56,7 @@
     "docs-test": "node tools/transforms/test.js",
     "redirects-test": "node tests/deployment/unit/test",
     "firebase-utils-test": "node tools/firebase-test-utils/test",
-    "tools-lint": "tslint --config \"tools/tslint.json\" --project \"tools/firebase-test-utils\" && eslint tools/ng-packages-installer",
+    "tools-lint": "eslint tools/firebase-test-utils && eslint tools/ng-packages-installer",
     "tools-test": "yarn docs-test && yarn boilerplate:test && jasmine tools/ng-packages-installer/index.spec.js && jasmine scripts/deploy-to-firebase.spec.js && yarn firebase-utils-test",
     "preserve-and-sync": "yarn docs",
     "serve-and-sync": "run-p \"docs-watch --watch-only\" \"start {@}\" --",

aio/tools/firebase-test-utils/.eslintrc.json

@@ -0,0 +1,23 @@
+{
+    "extends": "../../.eslintrc.json",
+    "overrides": [
+        {
+            "files": ["*.js"],
+            "env": {
+                "es6": true,
+                "node": true
+            },
+            "extends": [
+                "eslint:recommended"
+            ],
+            "parserOptions": {
+                "ecmaVersion": 2020
+            },
+            "rules": {
+                "quotes": ["error", "single"],
+                "semi": ["error", "always"],
+                "no-var": ["error"]
+            }
+        }
+    ]
+}

aio/tools/firebase-test-utils/FirebaseRedirect.ts

@@ -7,11 +7,10 @@ export class FirebaseRedirect {
   destination: string;
 
   constructor(readonly rawConfig: FirebaseRedirectConfig) {
-    const {source, regex, destination} = rawConfig;
-    this.source = (typeof source === 'string') ?
-      FirebaseRedirectSource.fromGlobPattern(source) :
-      FirebaseRedirectSource.fromRegexPattern(regex!);
-    this.destination = destination;
+    this.source = (rawConfig.regex === undefined) ?
+      FirebaseRedirectSource.fromGlobPattern(rawConfig.source) :
+      FirebaseRedirectSource.fromRegexPattern(rawConfig.regex);
+    this.destination = rawConfig.destination;
   }
 
   replace(url: string): string | undefined {

aio/tools/firebase-test-utils/FirebaseRedirectSource.spec.ts

@@ -344,21 +344,21 @@ function testSource(source: FirebaseRedirectSource, matches: string[], nonMatche
 function testGlobMatch(
     pattern: string,
     captures: { named?: string[], rest?: string[] },
-    matches: { [url: string]: object|undefined }) {
+    matches: { [url: string]: unknown|undefined }) {
   return testSourceMatch(FirebaseRedirectSource.fromGlobPattern(pattern), captures, matches);
 }
 
 function testRegexMatch(
     pattern: string,
     captures: { named?: string[], rest?: string[] },
-    matches: { [url: string]: object|undefined }) {
+    matches: { [url: string]: unknown|undefined }) {
   return testSourceMatch(FirebaseRedirectSource.fromRegexPattern(pattern), captures, matches);
 }
 
 function testSourceMatch(
     source: FirebaseRedirectSource,
     captures: { named?: string[], rest?: string[] },
-    matches: { [url: string]: object|undefined }) {
+    matches: { [url: string]: unknown|undefined }) {
   expect(source.namedGroups).toEqual(captures.named || []);
   expect(source.restNamedGroups).toEqual(captures.rest || []);
   Object.keys(matches).forEach(url => expect(source.match(url)).toEqual(matches[url]));

aio/tools/firebase-test-utils/FirebaseRedirectSource.ts

@@ -40,7 +40,7 @@ export class FirebaseRedirectSource {
             restNamedGroups.push(groupName);
             return `(?:${leadingSlash}(?<${groupName}>.🐷))?`;
           })
-          .replace(namedParam, `$1(?<$2>[^/]+)`)
+          .replace(namedParam, '$1(?<$2>[^/]+)')
           .replace(doubleStar, '$1.🐷$2')                 // use the pig to avoid replacing ** in next rule
           .replace(star, '[^/]*')                         // match a single segment
           .replace(possiblyEmptyInitialSegments, '(?:.*)')// deal with **/ special cases
@@ -89,6 +89,7 @@ export class FirebaseRedirectSource {
 
     const result: { [key: string]: string } = {};
     const names = this.regex.xregexp.captureNames || [];
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     names.forEach(name => result[name] = match.groups![name]);
     return result;
   }