Skip to content

Commit

Permalink
build: restrict visibility of npm_package targets (#27611)
Browse files Browse the repository at this point in the history 
dependencies on these cause very long rebuilds which have to re-package angular.
Such tests belong in the integration/ folder

PR Close #27611
  • Loading branch information
@alexeagle @mhevery
alexeagle authored and mhevery committed Dec 14, 2018
1 parent f5e7208 commit 63d395c
Show file tree
Hide file tree
Showing 18 changed files with 82 additions and 0 deletions.
5 changes: 5 additions & 0 deletions packages/animations/BUILD.bazel
View file
Expand Up @@ -27,6 +27,11 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = [
"//packages/compiler/test:__pkg__",
],
deps = [
":animations",
"//packages/animations/browser",
Expand Down
3 changes: 3 additions & 0 deletions packages/bazel/BUILD.bazel
View file
Expand Up @@ -13,6 +13,9 @@ npm_package(
"//packages/bazel/docs",
],
tags = ["release-with-framework"],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = ["//visibility:private"],
deps = [
"//packages/bazel/src/builders",
"//packages/bazel/src/ng_package:lib",
Expand Down
11 changes: 11 additions & 0 deletions packages/common/BUILD.bazel
View file
Expand Up @@ -30,6 +30,17 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = [
"//packages/bazel/test/ng_package:__pkg__",
"//packages/compiler-cli/test:__pkg__",
"//packages/compiler-cli/test/diagnostics:__pkg__",
"//packages/compiler-cli/test/ngcc:__pkg__",
"//packages/compiler-cli/test/transformers:__pkg__",
"//packages/compiler/test:__pkg__",
"//packages/language-service/test:__pkg__",
],
deps = [
"//packages/common",
"//packages/common/http",
Expand Down
3 changes: 3 additions & 0 deletions packages/compiler-cli/BUILD.bazel
View file
Expand Up @@ -46,6 +46,9 @@ npm_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = ["//visibility:private"],
deps = [
":compiler-cli",
"//packages/compiler-cli/src/ngcc",
Expand Down
5 changes: 5 additions & 0 deletions packages/compiler/BUILD.bazel
View file
Expand Up @@ -24,6 +24,11 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = [
"//packages/language-service/test:__pkg__",
],
deps = [
":compiler",
"//packages/compiler/testing",
Expand Down
11 changes: 11 additions & 0 deletions packages/core/BUILD.bazel
View file
Expand Up @@ -29,6 +29,17 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = [
"//packages/bazel/test/ng_package:__pkg__",
"//packages/compiler-cli/test:__pkg__",
"//packages/compiler-cli/test/diagnostics:__pkg__",
"//packages/compiler-cli/test/ngcc:__pkg__",
"//packages/compiler-cli/test/transformers:__pkg__",
"//packages/compiler/test:__pkg__",
"//packages/language-service/test:__pkg__",
],
deps = [
":core",
"//packages/core/testing",
Expand Down
3 changes: 3 additions & 0 deletions packages/elements/BUILD.bazel
View file
Expand Up @@ -31,6 +31,9 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = ["//visibility:private"],
deps = [
":elements",
],
Expand Down
6 changes: 6 additions & 0 deletions packages/forms/BUILD.bazel
View file
Expand Up @@ -25,6 +25,12 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = [
"//packages/compiler-cli/test/diagnostics:__pkg__",
"//packages/language-service/test:__pkg__",
],
deps = [
":forms",
],
Expand Down
3 changes: 3 additions & 0 deletions packages/http/BUILD.bazel
View file
Expand Up @@ -28,6 +28,9 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = ["//visibility:private"],
deps = [
":http",
"//packages/http/testing",
Expand Down
3 changes: 3 additions & 0 deletions packages/language-service/BUILD.bazel
View file
Expand Up @@ -27,6 +27,9 @@ npm_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = ["//visibility:private"],
deps = [
":language-service",
"//packages/language-service/bundles:language-service",
Expand Down
3 changes: 3 additions & 0 deletions packages/platform-browser-dynamic/BUILD.bazel
View file
Expand Up @@ -30,6 +30,9 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = ["//visibility:private"],
deps = [
":platform-browser-dynamic",
"//packages/platform-browser-dynamic/testing",
Expand Down
5 changes: 5 additions & 0 deletions packages/platform-browser/BUILD.bazel
View file
Expand Up @@ -31,6 +31,11 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = [
"//packages/compiler-cli/test:__pkg__",
],
deps = [
":platform-browser",
"//packages/platform-browser/animations",
Expand Down
3 changes: 3 additions & 0 deletions packages/platform-server/BUILD.bazel
View file
Expand Up @@ -37,6 +37,9 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = ["//visibility:private"],
deps = [
":platform-server",
"//packages/platform-server/testing",
Expand Down
3 changes: 3 additions & 0 deletions packages/platform-webworker-dynamic/BUILD.bazel
View file
Expand Up @@ -27,5 +27,8 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = ["//visibility:private"],
deps = [":platform-webworker-dynamic"],
)
3 changes: 3 additions & 0 deletions packages/platform-webworker/BUILD.bazel
View file
Expand Up @@ -27,6 +27,9 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = ["//visibility:private"],
deps = [
":platform-webworker",
],
Expand Down
6 changes: 6 additions & 0 deletions packages/router/BUILD.bazel
View file
Expand Up @@ -31,6 +31,12 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = [
"//packages/compiler-cli/test:__pkg__",
"//packages/compiler-cli/test/transformers:__pkg__",
],
deps = [
":router",
"//packages/router/testing",
Expand Down
3 changes: 3 additions & 0 deletions packages/service-worker/BUILD.bazel
View file
Expand Up @@ -51,6 +51,9 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = ["//visibility:private"],
deps = [
":service-worker",
"//packages/service-worker/config",
Expand Down
3 changes: 3 additions & 0 deletions packages/upgrade/BUILD.bazel
View file
Expand Up @@ -30,6 +30,9 @@ ng_package(
tags = [
"release-with-framework",
],
# Do not add more to this list.
# Dependencies on the full npm_package cause long re-builds.
visibility = ["//visibility:private"],
deps = [
":upgrade",
"//packages/upgrade/static",
Expand Down

0 comments on commit 63d395c

Please sign in to comment.