Skip to content

Commit

Permalink
Revert "refactor(compiler-cli): extract error documentation base url …
Browse files Browse the repository at this point in the history
…into separate file" (#43961)

This reverts commit bd5acf6.

PR Close #43961
  • Loading branch information
thePunderWoman committed Oct 26, 2021
1 parent 2d9d270 commit 7289264
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 41 deletions.
3 changes: 1 addition & 2 deletions packages/compiler-cli/src/ngtsc/diagnostics/index.ts
Expand Up @@ -6,8 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/

export {COMPILER_ERRORS_WITH_GUIDES} from './src/docs';
export {COMPILER_ERRORS_WITH_GUIDES, ERROR_DETAILS_PAGE_BASE_URL} from './src/docs';
export {FatalDiagnosticError, isFatalDiagnosticError, makeDiagnostic, makeRelatedInformation} from './src/error';
export {ErrorCode} from './src/error_code';
export {ERROR_DETAILS_PAGE_BASE_URL} from './src/error_details_base_url';
export {ngErrorCode, replaceTsWithNgInErrors} from './src/util';
7 changes: 7 additions & 0 deletions packages/compiler-cli/src/ngtsc/diagnostics/src/docs.ts
Expand Up @@ -8,6 +8,13 @@

import {ErrorCode} from './error_code';

/**
* Base URL for the error details page.
* Keep this value in sync with a similar const in
* `packages/core/src/render3/error_code.ts`.
*/
export const ERROR_DETAILS_PAGE_BASE_URL = 'https://angular.io/errors';

/**
* Contains a set of error messages that have detailed guides at angular.io.
* Full list of available error guides can be found at https://angular.io/errors
Expand Down

This file was deleted.

5 changes: 4 additions & 1 deletion packages/core/src/render3/error_code.ts
Expand Up @@ -6,7 +6,10 @@
* found in the LICENSE file at https://angular.io/license
*/

import {ERROR_DETAILS_PAGE_BASE_URL} from './error_details_base_url';
// Base URL for the error details page.
// Keep this value in sync with a similar const in
// `packages/compiler-cli/src/ngtsc/diagnostics/src/docs.ts`.
const ERROR_DETAILS_PAGE_BASE_URL = 'https://angular.io/errors';

export const enum RuntimeErrorCode {
// Internal Errors
Expand Down
19 changes: 0 additions & 19 deletions packages/core/src/render3/error_details_base_url.ts

This file was deleted.

0 comments on commit 7289264

Please sign in to comment.