Skip to content

Commit

Permalink
refactor(ivy): remove unnecessary binding from hello world
Browse files Browse the repository at this point in the history
  • Loading branch information
kara committed Mar 17, 2018
1 parent f258ec6 commit 84d73d1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 41 deletions.
36 changes: 0 additions & 36 deletions packages/core/test/bundling/hello_world/bundle.golden_symbols.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
{
"name": "NG_PROJECT_AS_ATTR_NAME"
},
{
"name": "NO_CHANGE"
},
{
"name": "Symbol$1"
},
Expand Down Expand Up @@ -44,9 +41,6 @@
{
"name": "appendChild"
},
{
"name": "bindingUpdated"
},
{
"name": "callHooks"
},
Expand Down Expand Up @@ -95,24 +89,12 @@
{
"name": "executeInitHooks"
},
{
"name": "findFirstRNode"
},
{
"name": "findNextRNodeSibling"
},
{
"name": "generateInitialInputs"
},
{
"name": "getDirectiveInstance"
},
{
"name": "getNextLNodeWithProjection"
},
{
"name": "getNextOrParentSiblingNode"
},
{
"name": "getOrCreateTView"
},
Expand All @@ -125,24 +107,12 @@
{
"name": "hostElement"
},
{
"name": "initBindings"
},
{
"name": "initChangeDetectorIfExisting"
},
{
"name": "insertChild"
},
{
"name": "interpolation1"
},
{
"name": "invertObject"
},
{
"name": "isDifferent"
},
{
"name": "isProceduralRenderer"
},
Expand Down Expand Up @@ -194,12 +164,6 @@
{
"name": "text"
},
{
"name": "textBinding"
},
{
"name": "throwErrorIfNoChangesMode"
},
{
"name": "tick"
},
Expand Down
7 changes: 2 additions & 5 deletions packages/core/test/bundling/hello_world/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,17 @@
* found in the LICENSE file at https://angular.io/license
*/

import {ɵT as T, ɵdefineComponent as defineComponent, ɵi1 as i1, ɵrenderComponent as renderComponent, ɵt as t} from '@angular/core';
import {ɵT as T, ɵdefineComponent as defineComponent, ɵrenderComponent as renderComponent} from '@angular/core';

class HelloWorld {
name = 'World';

static ngComponentDef = defineComponent({
type: HelloWorld,
tag: 'hello-world',
factory: () => new HelloWorld(),
template: function HelloWorldTemplate(ctx: HelloWorld, cm: boolean) {
if (cm) {
T(0);
T(0, 'Hello World!');
}
t(0, i1('Hello ', ctx.name, '!'));
}
});
}
Expand Down

0 comments on commit 84d73d1

Please sign in to comment.