fixup! feat(ivy): support lifecycle hooks of ViewContainerRef

angular · Apr 25, 2018 · 8dc9705 · 8dc9705
1 parent c460570
commit 8dc9705
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/packages/core/src/render3/instructions.ts b/packages/core/src/render3/instructions.ts
@@ -227,8 +227,7 @@ export function enterView(newView: LView, host: LElementNode | LViewNode | null)
  *
  * @param newView New state to become active
  * @param creationOnly An optional boolean to indicate that the view was processed in creation mode
- * only, i.e. the first update will be done later
- * @returns the previous state
+ * only, i.e. the first update will be done later. Only possible for dynamically created views.
  */
 export function leaveView(newView: LView, creationOnly?: boolean): void {
   if (!creationOnly) {

diff --git a/packages/core/test/render3/lifecycle_spec.ts b/packages/core/test/render3/lifecycle_spec.ts
@@ -2466,12 +2466,16 @@ describe('lifecycles', () => {
       function Template(rf: RenderFlags, ctx: any) {
         if (rf & RenderFlags.Create) {
           elementStart(0, 'parent');
-          elementStart(1, 'content');
-          elementEnd();
+          {
+            elementStart(1, 'content');
+            elementEnd();
+          }
           elementEnd();
           elementStart(2, 'parent');
-          elementStart(3, 'content');
-          elementEnd();
+          {
+            elementStart(3, 'content');
+            elementEnd();
+          }
           elementEnd();
         }
         if (rf & RenderFlags.Update) {