-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(compiler): Don't set expression text to synthetic
$implicit
whe…
…n empty (#40583) When parsing interpolations, if we encounter an empty interpolation (`{{}}`), the current code uses a "pretend" value of `$implicit` for the name as if the interplotion were really `{{$implicit}}`. This is problematic because the spans are then incorrect downstream since they are based off of the `$implicit` text. This commit changes the interpretation of empty interpolations so that the text is simply an empty string. Fixes angular/vscode-ng-language-service#1077 Fixes angular/vscode-ng-language-service#1078 PR Close #40583
- Loading branch information
Showing
3 changed files
with
26 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters