Skip to content

Commit

Permalink
docs: spelling changes in app.e2e-spec and validate-spec files (#41326)
Browse files Browse the repository at this point in the history 
PR Close #41326
  • Loading branch information
@MariosRadis @josephperrott
MariosRadis authored and josephperrott committed Mar 23, 2021
1 parent 0516fbb commit a92a89b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion aio/tests/e2e/src/app.e2e-spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ describe('site App', () => {
it('should have contributors listed in each group', async () => {
// WebDriver calls `scrollIntoView()` on the element to bring it into the visible area of the
// browser, before clicking it. By default, this aligns the top of the element to the top of
// the window. As a result, the element may end up behing the fixed top menu, thus being
// the window. As a result, the element may end up behind the fixed top menu, thus being
// unclickable. To avoid this, we click the element directly using JavaScript instead.
const clickButton =
(elementFinder: ElementFinder) => browser.executeScript('arguments[0].click()', elementFinder);
Expand Down
18 changes: 9 additions & 9 deletions dev-infra/commit-message/validate.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe('validate-commit-message.js', () => {
});

it('should skip max length limit for URLs', () => {
const msg = 'fix(compiler): this is just an usual commit message tile\n\n' +
const msg = 'fix(compiler): this is just a usual commit message title\n\n' +
'This is a normal commit message body which does not exceed the max length\n' +
'limit. For more details see the following super long URL:\n\n' +
'https://github.com/angular/components/commit/e2ace018ddfad10608e0e32932c43dcfef4095d7#diff-9879d6db96fd29134fc802214163b95a';
Expand Down Expand Up @@ -266,51 +266,51 @@ describe('validate-commit-message.js', () => {

describe('breaking change', () => {
it('should allow valid breaking change commit descriptions', () => {
const msgWithSummary = 'feat(compiler): this is just an usual commit message tile\n\n' +
const msgWithSummary = 'feat(compiler): this is just a usual commit message title\n\n' +
'This is a normal commit message body which does not exceed the max length\n' +
'limit. For more details see the following super long URL:\n\n' +
'BREAKING CHANGE: This is a summary of a breaking change.';
expectValidationResult(validateCommitMessage(msgWithSummary), VALID);

const msgWithDescription = 'feat(compiler): this is just an usual commit message tile\n\n' +
const msgWithDescription = 'feat(compiler): this is just a usual commit message title\n\n' +
'This is a normal commit message body which does not exceed the max length\n' +
'limit. For more details see the following super long URL:\n\n' +
'BREAKING CHANGE:\n\n' +
'This is a full description of the breaking change.';
expectValidationResult(validateCommitMessage(msgWithDescription), VALID);

const msgWithSummaryAndDescription =
'feat(compiler): this is just an usual commit message tile\n\n' +
'feat(compiler): this is just a usual commit message title\n\n' +
'This is a normal commit message body which does not exceed the max length\n' +
'limit. For more details see the following super long URL:\n\n' +
'BREAKING CHANGE: This is a summary of a breaking change.\n\n' +
'This is a full description of the breaking change.';
expectValidationResult(validateCommitMessage(msgWithSummaryAndDescription), VALID);

const msgWithNonBreaking = 'feat(compiler): this is just an usual commit message tile\n\n' +
const msgWithNonBreaking = 'feat(compiler): this is just a usual commit message title\n\n' +
'This is not a\n' +
'breaking change commit.';
expectValidationResult(validateCommitMessage(msgWithNonBreaking), VALID);
});

it('should fail for non-valid breaking change commit descriptions', () => {
const msgWithSummary = 'feat(compiler): this is just an usual commit message tile\n\n' +
const msgWithSummary = 'feat(compiler): this is just a usual commit message title\n\n' +
'This is a normal commit message body which does not exceed the max length\n' +
'limit. For more details see the following super long URL:\n\n' +
'BREAKING CHANGE This is a summary of a breaking change.';
expectValidationResult(
validateCommitMessage(msgWithSummary), INVALID,
[`The commit message body contains an invalid breaking change description.`]);

const msgWithPlural = 'feat(compiler): this is just an usual commit message tile\n\n' +
const msgWithPlural = 'feat(compiler): this is just a usual commit message title\n\n' +
'This is a normal commit message body which does not exceed the max length\n' +
'limit. For more details see the following super long URL:\n\n' +
'BREAKING CHANGES: This is a summary of a breaking change.';
expectValidationResult(
validateCommitMessage(msgWithPlural), INVALID,
[`The commit message body contains an invalid breaking change description.`]);

const msgWithDescription = 'feat(compiler): this is just an usual commit message tile\n\n' +
const msgWithDescription = 'feat(compiler): this is just a usual commit message title\n\n' +
'This is a normal commit message body which does not exceed the max length\n' +
'limit. For more details see the following super long URL:\n\n' +
'BREAKING CHANGE:\n' +
Expand All @@ -320,7 +320,7 @@ describe('validate-commit-message.js', () => {
[`The commit message body contains an invalid breaking change description.`]);

const msgWithSummaryAndDescription =
'feat(compiler): this is just an usual commit message tile\n\n' +
'feat(compiler): this is just a usual commit message title\n\n' +
'This is a normal commit message body which does not exceed the max length\n' +
'limit. For more details see the following super long URL:\n\n' +
'BREAKING CHANGE\n\n' +
Expand Down

0 comments on commit a92a89b

Please sign in to comment.