Skip to content

Commit

Permalink
refactor(core): temporarily mark subscribe methods as deprecated (#54342
Browse files Browse the repository at this point in the history
)

The `subscribe` methods on `ModelSignal` and `OutputEmitter` were marked as `@internal` which will break when the TCB needs to reference them. These changes make them `@deprecated` temporarily so we can address the properly later.

PR Close #54342
  • Loading branch information
crisbeto authored and thePunderWoman committed Feb 8, 2024
1 parent 38b01a3 commit adfc3f0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/core/src/authoring/model/model_signal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ export interface ModelSignal<T> extends WritableSignal<T> {
[ɵINPUT_SIGNAL_BRAND_READ_TYPE]: T;
[ɵINPUT_SIGNAL_BRAND_WRITE_TYPE]: T;

// TODO(crisbeto): mark this as @internal
/**
* Subscribes to changes in the model's value. Used by listener instructions at runtime.
* @internal
* @deprecated Do not use, will be removed.
*/
subscribe(callback: (value: T) => void): {unsubscribe: () => void};
}
Expand Down

0 comments on commit adfc3f0

Please sign in to comment.