Skip to content

Commit

Permalink
refactor(devtools): remove support for v11 and older versions of Angu…
Browse files Browse the repository at this point in the history
…lar (#45883)

In Angular v12 we introduced debugging APIs sufficient for DevTools.
Prior to that Angular DevTools accesses the logical data structures of
Ivy directly, which sometimes produces suboptimal results and skips
dynamically inserted content.

With the end of v11's LTS, we'll support only Angular v12 and up.

PR Close #45883
  • Loading branch information
mgechev authored and AndrewKushnir committed May 5, 2022
1 parent 58a8bd3 commit af36adf
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion devtools/README.md
Expand Up @@ -27,7 +27,7 @@ Angular DevTools is a Chrome extension that provides debugging and profiling cap

## Supported version

Angular DevTools supports Angular v9 and above, with Ivy enabled.
Angular DevTools supports Angular v12 and above, with Ivy enabled.

## Working on Angular DevTools

Expand Down
2 changes: 1 addition & 1 deletion devtools/docs/overview.md
Expand Up @@ -17,7 +17,7 @@

# DevTools Overview

Angular DevTools is a Chrome extension that provides debugging and profiling capabilities for Angular applications. Angular DevTools supports Angular v9 and above, with Ivy enabled.
Angular DevTools is a Chrome extension that provides debugging and profiling capabilities for Angular applications. Angular DevTools supports Angular v12 and above.

You can find Angular DevTools in the [Chrome Web Store](https://chrome.google.com/webstore/detail/angular-developer-tools/ienfalfjdbdpebioblfackkekamfmbnh).

Expand Down
Expand Up @@ -29,12 +29,12 @@ describe('angular-check', () => {
});

it('should work with new versions', () => {
setNgVersion('9.0.0');
setNgVersion('12.0.0');
expect(appIsSupportedAngularVersion()).toBeTrue();
});

it('should return false for older version', () => {
setNgVersion('8.0.0');
setNgVersion('9.0.0');
expect(appIsSupportedAngularVersion()).toBeFalse();
});

Expand Down
Expand Up @@ -26,7 +26,7 @@ export const appIsSupportedAngularVersion = (): boolean => {
return false;
}
const major = parseInt(version.toString().split('.')[0], 10);
return appIsAngular() && (major >= 9 || major === 0);
return appIsAngular() && (major >= 12 || major === 0);
};

/**
Expand Down
Expand Up @@ -6,8 +6,7 @@
</div>
<ng-template #notSupported>
<p class="text-message">
Angular Devtools only supports Angular versions 9 and above with
<a href="https://angular.io/guide/ivy" target="_blank">ivy</a> enabled.
Angular Devtools only supports Angular versions 12 and above
</p>
</ng-template>
</ng-container>
Expand Down
Expand Up @@ -60,7 +60,7 @@ <h4 class="header-text">Angular DevTools</h4>
</section>
<section>
<span class="material-icons md-48">settings</span>
<p>You can use DevTools with Angular v9+ <a href="https://angular.io/guide/ivy">Ivy.</a></p>
<p>You can use DevTools with Angular v12+</p>
</section>
</div>
</div>
Expand Down

0 comments on commit af36adf

Please sign in to comment.