Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(compiler-cli): allow declaration-only template type check members (…
…#34296) The metadata collector for View Engine compilations emits error symbols for static class members that have not been initialized, which prevents a library from building successfully when `strictMetadataEmit` is enabled, which is recommended for libraries to avoid issues in library consumers. This is troublesome for libraries that are adopting static members for the Ivy template type checker: these members don't need a value assignment as only their type is of importance, however this causes metadata errors. As such, a library used to be required to initialize the special static members to workaround this error, undesirably introducing a code-size overhead in terms of emitted JavaScript code. This commit modifies the collector logic to specifically ignore the special static members for Ivy's template type checker, preventing any errors from being recorded during the metadata collection. PR Close #34296
- Loading branch information
1 parent
edfaab6
commit bbb9412
Showing
2 changed files
with
29 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters