Skip to content

Commit

Permalink
fix(core): add additional component metadata to component ID generati…
Browse files Browse the repository at this point in the history
…on (#50336)

This commit add `exportAs`, `signals`, `inputs` and `outputs` into account when generating a component ID.

Co-authored-by: alan-agius4 <17563226+alan-agius4@users.noreply.github.com>

PR Close #50336
  • Loading branch information
AndrewKushnir committed May 17, 2023
1 parent 9afd90c commit c0ebe34
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/core/src/render3/definition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -696,6 +696,10 @@ function getComponentId(componentDef: ComponentDef<unknown>): string {
componentDef.decls,
componentDef.encapsulation,
componentDef.standalone,
componentDef.signals,
componentDef.exportAs,
JSON.stringify(componentDef.inputs),
JSON.stringify(componentDef.outputs),
// We cannot use 'componentDef.type.name' as the name of the symbol will change and will not
// match in the server and browser bundles.
Object.getOwnPropertyNames(componentDef.type.prototype),
Expand Down

0 comments on commit c0ebe34

Please sign in to comment.