build: switch devmode output to es2015 (#44505)

To make our test output i.e. devmode output more aligned with what we produce in the NPM packages, or to be more aligned with what Angular applications will usually consume, the devmode output is switched from ES5 to ES2015. Additionally various tsconfigs (outside of Bazel) have been updated to match with the other parts of the build. The rules are: ES2015 for test configurations, ES2020 for actual code that will end up being shipped (this includes the IDE-only tsconfigs). PR Close #44505
angular · Jan 5, 2022 · c46d533 · c46d533
1 parent 8388151
commit c46d533
Show file tree

Hide file tree

Showing 87 changed files with 134 additions and 250 deletions.
diff --git a/packages/animations/browser/test/BUILD.bazel b/packages/animations/browser/test/BUILD.bazel
@@ -30,7 +30,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_es5"],
+    bootstrap = ["//tools/testing:node_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/animations/test/BUILD.bazel b/packages/animations/test/BUILD.bazel
@@ -20,7 +20,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_es5"],
+    bootstrap = ["//tools/testing:node_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/bazel/src/ng_module/ng_module.bzl b/packages/bazel/src/ng_module/ng_module.bzl
@@ -275,6 +275,10 @@ def _ngc_tsconfig(ctx, files, srcs, **kwargs):
     if not is_devmode:
         # Note: Keep in sync with the `prodmode_target` for `ts_library` in `tools/defaults.bzl`
         tsconfig["compilerOptions"]["target"] = "es2020"
+    else:
+        # For devmode output, we use ES2015 to match with what `ts_library` produces by default.
+        # https://github.com/bazelbuild/rules_nodejs/blob/9b36274dba34204625579463e3da054a9f42cb47/packages/typescript/internal/build_defs.bzl#L83.
+        tsconfig["compilerOptions"]["target"] = "es2015"
 
     return tsconfig
 

diff --git a/packages/bazel/src/ngc-wrapped/tsconfig.json b/packages/bazel/src/ngc-wrapped/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "lib": ["es5", "es2015.collection", "es2015.core"],
+    "lib": ["es2015"],
     "types": ["node"],
     "esModuleInterop": true,
     "downlevelIteration": true

diff --git a/packages/bazel/test/ngc-wrapped/tsconfig.json b/packages/bazel/test/ngc-wrapped/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "lib": ["es5", "es2015.collection", "es2015.core"],
+    "lib": ["es2015"],
     "types": ["node", "jasmine"],
     "esModuleInterop": true
   }

diff --git a/packages/benchpress/test/BUILD.bazel b/packages/benchpress/test/BUILD.bazel
@@ -15,7 +15,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_es5"],
+    bootstrap = ["//tools/testing:node_es2015"],
     deps = [
         ":test_lib",
         "//packages/benchpress",

diff --git a/packages/common/http/test/BUILD.bazel b/packages/common/http/test/BUILD.bazel
@@ -27,7 +27,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_es5"],
+    bootstrap = ["//tools/testing:node_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/common/http/testing/test/BUILD.bazel b/packages/common/http/testing/test/BUILD.bazel
@@ -24,7 +24,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_es5"],
+    bootstrap = ["//tools/testing:node_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/common/test/BUILD.bazel b/packages/common/test/BUILD.bazel
@@ -38,7 +38,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_es5"],
+    bootstrap = ["//tools/testing:node_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/common/upgrade/test/BUILD.bazel b/packages/common/upgrade/test/BUILD.bazel
@@ -23,7 +23,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_es5"],
+    bootstrap = ["//tools/testing:node_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel
@@ -21,7 +21,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_es5"],
+    bootstrap = ["//tools/testing:node_es2015"],
     deps = [
         ":test_lib",
         "//packages/platform-server",

diff --git a/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel b/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel
@@ -19,7 +19,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_es5"],
+    bootstrap = ["//tools/testing:node_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/integrationtest/flat_module/tsconfig-build.json b/packages/compiler-cli/integrationtest/flat_module/tsconfig-build.json
@@ -10,12 +10,12 @@
     "baseUrl": ".",
     "declaration": true,
     "experimentalDecorators": true,
-    "lib": ["es6", "dom"],
+    "lib": ["es2015", "dom"],
     "moduleResolution": "node",
     "noImplicitAny": true,
     "outDir": "../node_modules/flat_module",
     "rootDir": "",
-    "target": "es5",
+    "target": "es2015",
     "typeRoots": ["../node_modules/@types"]
  },
 

diff --git a/packages/compiler-cli/integrationtest/ngtools_src/tsconfig-build.json b/packages/compiler-cli/integrationtest/ngtools_src/tsconfig-build.json
@@ -8,11 +8,11 @@
     "baseUrl": ".",
     "declaration": true,
     "experimentalDecorators": true,
-    "lib": ["es6", "dom"],
+    "lib": ["es2015", "dom"],
     "moduleResolution": "node",
     "noImplicitAny": true,
     "rootDir": "",
-    "target": "es5",
+    "target": "es2015",
     "types": []
   }
 }
diff --git a/packages/compiler-cli/integrationtest/third_party_src/tsconfig-build.json b/packages/compiler-cli/integrationtest/third_party_src/tsconfig-build.json
@@ -8,12 +8,12 @@
     "baseUrl": ".",
     "declaration": true,
     "experimentalDecorators": true,
-    "lib": ["es6", "dom"],
+    "lib": ["es2015", "dom"],
     "moduleResolution": "node",
     "noImplicitAny": true,
     "outDir": "../node_modules/third_party",
     "rootDir": "",
-    "target": "es5",
+    "target": "es2015",
     "typeRoots": ["../node_modules/@types"]
  }
 }
diff --git a/packages/compiler-cli/integrationtest/tsconfig-build.json b/packages/compiler-cli/integrationtest/tsconfig-build.json
@@ -12,7 +12,7 @@
     "baseUrl": ".",
     "declaration": true,
     "experimentalDecorators": true,
-    "lib": ["es6", "dom"],
+    "lib": ["es2015", "dom"],
     "moduleResolution": "node",
     "noImplicitAny": true,
     "noUnusedLocals": true,
@@ -23,7 +23,7 @@
     // compatible with the option. Disabled until the integration test support the strict flag.
     // TODO(devversion): this has been enabled without the integration test code being
     "strictPropertyInitialization": false,
-    "target": "es5",
+    "target": "es2015",
     "typeRoots": ["node_modules/@types"]
   },
 

diff --git a/packages/compiler-cli/integrationtest/tsconfig-xi18n.json b/packages/compiler-cli/integrationtest/tsconfig-xi18n.json
@@ -9,13 +9,13 @@
     "baseUrl": ".",
     "declaration": true,
     "experimentalDecorators": true,
-    "lib": ["es6", "dom"],
+    "lib": ["es2015", "dom"],
     "moduleResolution": "node",
     "noImplicitAny": true,
     "outDir": "./xi18n-out",
     "rootDir": "",
     "skipLibCheck": true,
-    "target": "es5",
+    "target": "es2015",
     "typeRoots": ["node_modules/@types"]
   },
 

diff --git a/packages/compiler-cli/linker/babel/test/BUILD.bazel b/packages/compiler-cli/linker/babel/test/BUILD.bazel
@@ -29,7 +29,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/linker/test/BUILD.bazel b/packages/compiler-cli/linker/test/BUILD.bazel
@@ -24,7 +24,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/ngcc/test/BUILD.bazel b/packages/compiler-cli/ngcc/test/BUILD.bazel
@@ -38,7 +38,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     data = [
         "//packages/compiler-cli/src/ngtsc/testing/fake_core:npm_package",
     ],
@@ -90,7 +90,7 @@ babel(
 jasmine_node_test(
     name = "integration",
     timeout = "long",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     data = [
         ":fesm5_angular_core",
         "@npm//@angular/common-12",

diff --git a/packages/compiler-cli/src/ngtsc/annotations/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/annotations/test/BUILD.bazel
@@ -31,7 +31,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/core/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/core/test/BUILD.bazel
@@ -25,7 +25,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/cycles/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/cycles/test/BUILD.bazel
@@ -1,7 +1,7 @@
-package(default_visibility = ["//visibility:public"])
-
 load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
 
+package(default_visibility = ["//visibility:public"])
+
 ts_library(
     name = "test_lib",
     testonly = True,
@@ -21,7 +21,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/entry_point/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/entry_point/test/BUILD.bazel
@@ -19,7 +19,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/file_system/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/file_system/test/BUILD.bazel
@@ -17,7 +17,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/imports/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/imports/test/BUILD.bazel
@@ -23,7 +23,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/incremental/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/incremental/test/BUILD.bazel
@@ -23,7 +23,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/indexer/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/indexer/test/BUILD.bazel
@@ -23,7 +23,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/logging/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/logging/test/BUILD.bazel
@@ -15,7 +15,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/metadata/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/metadata/test/BUILD.bazel
@@ -24,7 +24,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     data = [
         "//packages/compiler-cli/src/ngtsc/testing/fake_core:npm_package",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/partial_evaluator/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/partial_evaluator/test/BUILD.bazel
@@ -24,7 +24,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/reflection/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/reflection/test/BUILD.bazel
@@ -20,7 +20,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/scope/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/scope/test/BUILD.bazel
@@ -1,7 +1,7 @@
-package(default_visibility = ["//visibility:public"])
-
 load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
 
+package(default_visibility = ["//visibility:public"])
+
 ts_library(
     name = "test_lib",
     testonly = True,
@@ -25,7 +25,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/shims/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/shims/test/BUILD.bazel
@@ -21,7 +21,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/sourcemaps/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/sourcemaps/test/BUILD.bazel
@@ -21,7 +21,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/transform/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/transform/test/BUILD.bazel
@@ -24,7 +24,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],

diff --git a/packages/compiler-cli/src/ngtsc/translator/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/translator/test/BUILD.bazel
@@ -18,7 +18,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    bootstrap = ["//tools/testing:node_no_angular_es5"],
+    bootstrap = ["//tools/testing:node_no_angular_es2015"],
     deps = [
         ":test_lib",
     ],