build: move repeated tsconfig attributes to a macro (#20964)

This helps ensure we use the same tsconfig.json file for all compilations. Next steps are to make it the same tsconfig.json file used by the editor PR Close #20964
angular · Jan 10, 2018 · c4f02e2 · c4f02e2
1 parent f15ca6c
commit c4f02e2
Show file tree

Hide file tree

Showing 54 changed files with 83 additions and 123 deletions.
diff --git a/packages/BUILD.bazel b/packages/BUILD.bazel
@@ -5,16 +5,9 @@ exports_files([
     "tsconfig.json",
 ])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_config", "ts_library")
-
-ts_config(
-    name = "tsconfig",
-    src = ":tsconfig-build.json",
-    deps = [],
-)
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "types",
     srcs = glob(["*.ts"]),
-    tsconfig = ":tsconfig",
 )
diff --git a/packages/animations/BUILD.bazel b/packages/animations/BUILD.bazel
@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "animations",
@@ -11,7 +11,6 @@ ts_library(
         ],
     ),
     module_name = "@angular/animations",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/core",
     ],

diff --git a/packages/animations/browser/BUILD.bazel b/packages/animations/browser/BUILD.bazel
@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "browser",
@@ -11,7 +11,6 @@ ts_library(
         ],
     ),
     module_name = "@angular/animations/browser",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/animations",
     ],

diff --git a/packages/animations/browser/test/BUILD.bazel b/packages/animations/browser/test/BUILD.bazel
@@ -1,10 +1,9 @@
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "test",
     testonly = 1,
     srcs = glob(["**/*.ts"]),
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages:types",
         "//packages/animations",

diff --git a/packages/animations/browser/testing/BUILD.bazel b/packages/animations/browser/testing/BUILD.bazel
@@ -1,13 +1,12 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/animations/browser/testing",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/animations",
         "//packages/animations/browser",

diff --git a/packages/animations/test/BUILD.bazel b/packages/animations/test/BUILD.bazel
@@ -1,10 +1,9 @@
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "test",
     testonly = 1,
     srcs = glob(["test/**/*.ts"]),
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages:types",
         "//packages/animations",

diff --git a/packages/common/BUILD.bazel b/packages/common/BUILD.bazel
@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "common",
@@ -11,7 +11,6 @@ ts_library(
         ],
     ),
     module_name = "@angular/common",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/core",
         "@rxjs",

diff --git a/packages/common/http/BUILD.bazel b/packages/common/http/BUILD.bazel
@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "http",
@@ -11,7 +11,6 @@ ts_library(
         ],
     ),
     module_name = "@angular/common/http",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/common",
         "//packages/core",

diff --git a/packages/common/http/testing/BUILD.bazel b/packages/common/http/testing/BUILD.bazel
@@ -1,13 +1,12 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/common/http/testing",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/common/http",
         "//packages/core",

diff --git a/packages/common/locales/BUILD.bazel b/packages/common/locales/BUILD.bazel
@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "locales",
@@ -9,7 +9,4 @@ ts_library(
         exclude = ["closure-locale.ts"],
     ),
     module_name = "@angular/common/locales",
-    tsconfig = "//packages:tsconfig",
-    deps = [
-    ],
 )
diff --git a/packages/common/test/BUILD.bazel b/packages/common/test/BUILD.bazel
@@ -1,4 +1,5 @@
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library", "ts_web_test")
+load("//tools:defaults.bzl", "ts_library")
+load("@build_bazel_rules_typescript//:defs.bzl", "ts_web_test")
 load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test")
 
 ts_library(
@@ -8,7 +9,6 @@ ts_library(
         ["**/*.ts"],
         exclude = ["**/*_node_only_spec.ts"],
     ),
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/common",
         "//packages/common/locales",

diff --git a/packages/common/testing/BUILD.bazel b/packages/common/testing/BUILD.bazel
@@ -1,13 +1,12 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/common/testing",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/common",
         "//packages/core",

diff --git a/packages/compiler/BUILD.bazel b/packages/compiler/BUILD.bazel
@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "compiler",
@@ -11,5 +11,4 @@ ts_library(
         ],
     ),
     module_name = "@angular/compiler",
-    tsconfig = "//packages:tsconfig",
 )
diff --git a/packages/compiler/test/BUILD.bazel b/packages/compiler/test/BUILD.bazel
@@ -1,4 +1,5 @@
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library", "ts_web_test")
+load("//tools:defaults.bzl", "ts_library")
+load("@build_bazel_rules_typescript//:defs.bzl", "ts_web_test")
 load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test")
 
 ts_library(
@@ -8,7 +9,6 @@ ts_library(
         ["**/*.ts"],
         exclude = ["**/*_node_only_spec.ts"],
     ),
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages:types",
         "//packages/common",
@@ -27,7 +27,6 @@ ts_library(
     name = "test_node_only_lib",
     testonly = 1,
     srcs = glob(["**/*_node_only_spec.ts"]),
-    tsconfig = "//packages:tsconfig",
     deps = [
         ":test_lib",
         "//packages/compiler",

diff --git a/packages/compiler/testing/BUILD.bazel b/packages/compiler/testing/BUILD.bazel
@@ -1,13 +1,12 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/compiler/testing",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages:types",
         "//packages/compiler",

diff --git a/packages/core/BUILD.bazel b/packages/core/BUILD.bazel
@@ -1,7 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@angular//:index.bzl", "ng_module")
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
 ng_module(
     name = "core",
@@ -12,7 +11,6 @@ ng_module(
         ],
     ),
     module_name = "@angular/core",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages:types",
         "@rxjs",

diff --git a/packages/core/test/BUILD.bazel b/packages/core/test/BUILD.bazel
@@ -1,6 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library", "ts_web_test")
+load("//tools:defaults.bzl", "ts_library")
+load("@build_bazel_rules_typescript//:defs.bzl", "ts_web_test")
 load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test")
 
 ts_library(
@@ -13,7 +14,6 @@ ts_library(
             "render3/**/*.ts",
         ],
     ),
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/animations",
         "//packages/animations/browser",
@@ -37,7 +37,6 @@ ts_library(
     name = "test_node_only_lib",
     testonly = 1,
     srcs = glob(["**/*_node_only_spec.ts"]),
-    tsconfig = "//packages:tsconfig",
     deps = [
         ":test_lib",
         "//packages/compiler",

diff --git a/packages/core/test/render3/BUILD.bazel b/packages/core/test/render3/BUILD.bazel
@@ -1,6 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library", "ts_web_test")
+load("//tools:defaults.bzl", "ts_library")
+load("@build_bazel_rules_typescript//:defs.bzl", "ts_web_test")
 load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test")
 
 ts_library(
@@ -14,6 +15,7 @@ ts_library(
             "load_domino.ts",
         ],
     ),
+    # TODO(alexeagle): should not be different tsconfig
     tsconfig = "//packages:tsconfig.json",
     deps = [
         "//packages:types",
@@ -34,7 +36,6 @@ ts_library(
         "domino.d.ts",
         "load_domino.ts",
     ],
-    tsconfig = "//packages:tsconfig",
     deps = [
         ":render3_lib",
         "//packages/platform-browser",

diff --git a/packages/core/testing/BUILD.bazel b/packages/core/testing/BUILD.bazel
@@ -1,13 +1,12 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/core/testing",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages:types",
         "//packages/core",

diff --git a/packages/forms/BUILD.bazel b/packages/forms/BUILD.bazel
@@ -1,7 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@angular//:index.bzl", "ng_module")
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
 ng_module(
     name = "forms",
@@ -12,7 +11,6 @@ ng_module(
         ],
     ),
     module_name = "@angular/forms",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/core",
         "//packages/platform-browser",

diff --git a/packages/forms/test/BUILD.bazel b/packages/forms/test/BUILD.bazel
@@ -1,11 +1,11 @@
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library", "ts_web_test")
+load("//tools:defaults.bzl", "ts_library")
+load("@build_bazel_rules_typescript//:defs.bzl", "ts_web_test")
 load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test")
 
 ts_library(
     name = "test_lib",
     testonly = 1,
     srcs = glob(["**/*.ts"]),
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/core",
         "//packages/core/testing",

diff --git a/packages/http/BUILD.bazel b/packages/http/BUILD.bazel
@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "http",
@@ -11,7 +11,6 @@ ts_library(
         ],
     ),
     module_name = "@angular/http",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/core",
         "//packages/platform-browser",

diff --git a/packages/http/test/BUILD.bazel b/packages/http/test/BUILD.bazel
@@ -1,11 +1,11 @@
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library", "ts_web_test")
+load("//tools:defaults.bzl", "ts_library")
+load("@build_bazel_rules_typescript//:defs.bzl", "ts_web_test")
 load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test")
 
 ts_library(
     name = "test_lib",
     testonly = 1,
     srcs = glob(["**/*.ts"]),
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/core",
         "//packages/core/testing",

diff --git a/packages/http/testing/BUILD.bazel b/packages/http/testing/BUILD.bazel
@@ -1,13 +1,12 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/http/testing",
-    tsconfig = "//packages:tsconfig",
     deps = [
         "//packages/core",
         "//packages/http",