feat(devtools): renaming shell-chrome (#44952)

Renaming `shell-chrome` to `shell-browser` contains the build that supports both browsers.

PR Close #44952

devtools/DEVELOPING.md

@@ -14,7 +14,7 @@ To run the extension in development mode run:
 ng serve
 ```
 
-This would start a development server that you can access on http://localhost:4200. In development, Angular DevTools uses a "development shell." This is different from "chrome shell" in a way, that it runs the user's app in an iframe. DevTools then communicate with the user's app via message passing.
+This would start a development server that you can access on <http://localhost:4200>. In development, Angular DevTools uses a "development shell." This is different from "chrome shell" in a way, that it runs the user's app in an iframe. DevTools then communicate with the user's app via message passing.
 
 ## Building the extension
 
@@ -24,10 +24,10 @@ To build the Angular DevTools Chrome extension run:
 npm run release
 ```
 
-This would output the production assets of the app in `dist/shell-chrome`. If you want to build the extension with development settings (i.e., not minified sources), just run:
+This would output the production assets of the app in `dist/shell-browser`. If you want to build the extension with development settings (i.e., not minified sources), just run:
 
 ```
-ng build shell-chrome
+ng build shell-browser
 ```
 
-Later on, you can install the extension from `dist/shell-chrome` following the guide from [here](https://developer.chrome.com/apps/external_extensions).
+Later on, you can install the extension from `dist/shell-browser` following the guide from [here](https://developer.chrome.com/apps/external_extensions).

devtools/README.md

@@ -47,7 +47,7 @@ yarn run devtools:devserver
 1. After installation, generate chrome build by running `yarn build:chrome`
 2. Navigate to `chrome://extensions` and enable Developer mode.
 3. Choose "Load unpacked extension".
-4. In the dialog, select the directory `dist/shell-chrome`.
+4. In the dialog, select the directory `dist/shell-browser`.
 
 ## Reporting issues
 

devtools/projects/shell-chrome/src/BUILD.bazel → devtools/projects/shell-browser/src/BUILD.bazel

@@ -251,8 +251,8 @@ ng_module(
     ],
     deps = [
         "//devtools/projects/ng-devtools",
-        "//devtools/projects/shell-chrome/src/app",
-        "//devtools/projects/shell-chrome/src/environments:environment",
+        "//devtools/projects/shell-browser/src/app",
+        "//devtools/projects/shell-browser/src/environments:environment",
         "//packages/common",
         "//packages/common/http",
         "//packages/core",
@@ -305,8 +305,8 @@ config_setting(
 genrule(
     name = "copy_manifest",
     srcs = select({
-        ":browser_chrome": ["//devtools/projects/shell-chrome/src/manifest:manifest.chrome.json"],
-        ":browser_firefox": ["//devtools/projects/shell-chrome/src/manifest:manifest.firefox.json"],
+        ":browser_chrome": ["//devtools/projects/shell-browser/src/manifest:manifest.chrome.json"],
+        ":browser_firefox": ["//devtools/projects/shell-browser/src/manifest:manifest.firefox.json"],
     }),
     outs = ["manifest.json"],
     cmd = "cp $< $@",
@@ -320,13 +320,13 @@ pkg_web(
         ":devtools_bundle",
         ":prod_app_static_files",
         "//devtools/projects/ng-devtools/src/lib/images",
-        "//devtools/projects/shell-chrome/src:devtools.html",
-        "//devtools/projects/shell-chrome/src/app:backend_bundle",
-        "//devtools/projects/shell-chrome/src/app:background_bundle",
-        "//devtools/projects/shell-chrome/src/app:content_script_bundle",
-        "//devtools/projects/shell-chrome/src/app:ng_validate_bundle",
-        "//devtools/projects/shell-chrome/src/assets",
-        "//devtools/projects/shell-chrome/src/popups",
+        "//devtools/projects/shell-browser/src:devtools.html",
+        "//devtools/projects/shell-browser/src/app:backend_bundle",
+        "//devtools/projects/shell-browser/src/app:background_bundle",
+        "//devtools/projects/shell-browser/src/app:content_script_bundle",
+        "//devtools/projects/shell-browser/src/app:ng_validate_bundle",
+        "//devtools/projects/shell-browser/src/assets",
+        "//devtools/projects/shell-browser/src/popups",
     ],
     additional_root_paths = [
         "projects/ng-devtools/src/lib",

devtools/projects/shell-chrome/src/app/BUILD.bazel → devtools/projects/shell-browser/src/app/BUILD.bazel

@@ -30,8 +30,8 @@ ng_module(
         "//devtools/projects/ng-devtools-backend/src/lib:component_tree",
         "//devtools/projects/ng-devtools-backend/src/lib:highlighter",
         "//devtools/projects/protocol",
-        "//devtools/projects/shell-chrome/src/app:backend",
-        "//devtools/projects/shell-chrome/src/app:background",
+        "//devtools/projects/shell-browser/src/app:backend",
+        "//devtools/projects/shell-browser/src/app:background",
         "//packages/core",
         "//packages/platform-browser",
         "//packages/platform-browser/animations",
@@ -67,7 +67,7 @@ ts_library(
     ],
     deps = [
         "//devtools/projects/ng-devtools",
-        "//devtools/projects/shell-chrome/src/environments:environment",
+        "//devtools/projects/shell-browser/src/environments:environment",
         "@npm//@types",
     ],
 )
@@ -126,7 +126,7 @@ ts_library(
     srcs = [
         "background.ts",
     ],
-    deps = ["//devtools/projects/shell-chrome/src/app:ng_validate"],
+    deps = ["//devtools/projects/shell-browser/src/app:ng_validate"],
 )
 
 ts_library(
@@ -138,7 +138,7 @@ ts_library(
         ":same_page_message_bus",
         "//devtools/projects/ng-devtools-backend",
         "//devtools/projects/ng-devtools-backend/src/lib:highlighter",
-        "//devtools/projects/shell-chrome/src/app:chrome_window_extensions",
+        "//devtools/projects/shell-browser/src/app:chrome_window_extensions",
         "@npm//@types",
     ],
 )

package.json

@@ -37,8 +37,8 @@
     "ts-circular-deps:approve": "yarn -s ng-dev ts-circular-deps approve --config ./packages/circular-deps-test.conf.js",
     "check-tooling-setup": "yarn tsc --project .ng-dev/tsconfig.json",
     "devtools:devserver": "ibazel run //devtools/src:devserver",
-    "devtools:build:chrome": "bazelisk build --config snapshot //devtools/projects/shell-chrome/src:prodapp --define browser=chrome",
-    "devtools:build:firefox": "bazelisk build --config snapshot //devtools/projects/shell-chrome/src:prodapp --define browser=firefox",
+    "devtools:build:chrome": "bazelisk build --config snapshot //devtools/projects/shell-browser/src:prodapp --define browser=chrome",
+    "devtools:build:firefox": "bazelisk build --config snapshot //devtools/projects/shell-browser/src:prodapp --define browser=firefox",
     "devtools:test": "bazelisk test --config snapshot //devtools/... --define browser=chrome"
   },
   "// 1": "dependencies are used locally and by bazel",