docs(docs-infra): Go zoneless and enable the zoneless scheduler

angular · Apr 13, 2024 · d7f2849 · d7f2849
1 parent 571a61b
commit d7f2849
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 24 deletions.
diff --git a/adev/BUILD.bazel b/adev/BUILD.bazel
@@ -78,7 +78,7 @@ APPLICATION_DEPS = [
     "@npm//@lezer/javascript",
     "@npm//@lezer/common",
     "@npm//@xterm/xterm",
-    "@npm//xterm-addon-fit",
+    "@npm//@xterm/addon-fit",
     "@npm//angular-split",
 ]
 

diff --git a/adev/angular.json b/adev/angular.json
@@ -20,11 +20,16 @@
           "builder": "@angular-devkit/build-angular:application",
           "options": {
             "externalDependencies": ["path"],
+            "define": {
+              // Until this is merged https://github.com/xtermjs/xterm.js/issues/5030
+              "self": "this"
+            },
             "outputPath": "dist/angular-dev",
             "index": "src/index.html",
             "browser": "src/main.ts",
             "server": "src/main.server.ts",
-            "polyfills": ["src/polyfills.ts", "zone.js"],
+            "ssr": true,
+            "polyfills": [],
             "tsConfig": "tsconfig.app.json",
             "inlineStyleLanguage": "scss",
             "assets": ["src/favicon.ico", "src/robots.txt", "src/assets"],

diff --git a/adev/src/app/app.config.ts b/adev/src/app/app.config.ts
@@ -14,6 +14,7 @@ import {
   ErrorHandler,
   inject,
   provideZoneChangeDetection,
+  ɵprovideZonelessChangeDetection,
 } from '@angular/core';
 import {
   DOCS_CONTENT_LOADER,
@@ -68,6 +69,7 @@ export const appConfig: ApplicationConfig = {
         },
       }),
     ),
+    ɵprovideZonelessChangeDetection(),
     provideClientHydration(),
     provideHttpClient(withFetch()),
     provideAnimationsAsync(),
@@ -91,7 +93,6 @@ export const appConfig: ApplicationConfig = {
       deps: [DOCUMENT],
     },
     {provide: TitleStrategy, useClass: ADevTitleStrategy},
-    provideZoneChangeDetection({eventCoalescing: true}),
     ReferenceScrollHandler,
   ],
 };
diff --git a/adev/src/app/editor/terminal/terminal-handler.service.ts b/adev/src/app/editor/terminal/terminal-handler.service.ts
@@ -8,7 +8,7 @@
 
 import {Injectable} from '@angular/core';
 import {Terminal} from '@xterm/xterm';
-import {FitAddon} from 'xterm-addon-fit';
+import {FitAddon} from '@xterm/addon-fit';
 import {InteractiveTerminal} from './interactive-terminal';
 
 export enum TerminalType {

diff --git a/adev/src/polyfills.ts b/adev/src/polyfills.ts
diff --git a/adev/tsconfig.app.json b/adev/tsconfig.app.json
@@ -5,6 +5,6 @@
     "outDir": "../../out-tsc/app",
     "types": ["node"]
   },
-  "files": ["src/main.ts", "src/main.server.ts", "src/polyfills.ts"],
+  "files": ["src/main.ts", "src/main.server.ts"],
   "include": ["src/**/*.d.ts", "../../node_modules/@types/dom-navigation/index.d.ts"]
 }
diff --git a/package.json b/package.json
@@ -91,6 +91,7 @@
     "@types/shelljs": "^0.8.6",
     "@types/systemjs": "6.13.5",
     "@types/yargs": "^17.0.3",
+    "@xterm/addon-fit": "^0.10.0",
     "angular-1.5": "npm:angular@1.5",
     "angular-1.6": "npm:angular@1.6",
     "angular-1.7": "npm:angular@1.7",
@@ -183,6 +184,7 @@
     "@types/inquirer": "^9.0.3",
     "@types/jsdom": "^21.1.5",
     "@typescript/vfs": "^1.5.0",
+    "@xterm/xterm": "^5.4.0",
     "@yarnpkg/lockfile": "^1.1.0",
     "adm-zip": "^0.5.10",
     "angular-split": "^17.1.1",
@@ -218,9 +220,7 @@
     "tslint-no-toplevel-property-access": "0.0.2",
     "typed-graphqlify": "^3.1.1",
     "vrsource-tslint-rules": "6.0.0",
-    "xregexp": "^5.1.1",
-    "@xterm/xterm": "^5.4.0",
-    "xterm-addon-fit": "^0.8.0"
+    "xregexp": "^5.1.1"
   },
   "// 3": "Ensure that transitive dependencies on `https-proxy-agent` are at minimum v5 as older versions patch NodeJS directly, breaking tools like webdriver which is used by the karma-sauce-launcher as an example.",
   "// 4": "Ensure that a single instance of the `saucelabs` package is used. Protractor and the Karma sauce launcher pull this package as dependency. A single instance allows for e.g. easier patching in the Karma config.",

diff --git a/yarn.lock b/yarn.lock
@@ -4764,6 +4764,11 @@
   resolved "https://registry.yarnpkg.com/@xmldom/xmldom/-/xmldom-0.8.10.tgz#a1337ca426aa61cef9fe15b5b28e340a72f6fa99"
   integrity sha512-2WALfTl4xo2SkGCYRt6rDTFfk9R1czmBvUQy12gK2KuRKIpWEhcbbzy8EZXtz/jkRqHX8bFEc6FC1HjX4TUWYw==
 
+"@xterm/addon-fit@^0.10.0":
+  version "0.10.0"
+  resolved "https://registry.yarnpkg.com/@xterm/addon-fit/-/addon-fit-0.10.0.tgz#bebf87fadd74e3af30fdcdeef47030e2592c6f55"
+  integrity sha512-UFYkDm4HUahf2lnEyHvio51TNGiLK66mqP2JoATy7hRZeXaGMRDr00JiSF7m63vR5WKATF605yEggJKsw0JpMQ==
+
 "@xterm/xterm@^5.4.0":
   version "5.5.0"
   resolved "https://registry.yarnpkg.com/@xterm/xterm/-/xterm-5.5.0.tgz#275fb8f6e14afa6e8a0c05d4ebc94523ff775396"