Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test(bazel): Use local_repository to load Angular
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406
- Loading branch information
Showing
7 changed files
with
956 additions
and
180 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { browser, by, element } from 'protractor'; | ||
|
|
||
| export class AppPage { | ||
| navigateTo() { | ||
| return browser.get('/') as Promise<any>; | ||
| } | ||
|
|
||
| getTitleText() { | ||
| return element(by.css('app-root h1')).getText() as Promise<string>; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| const fs = require('fs'); | ||
|
|
||
| function main(argv) { | ||
| argv = argv.slice(2); | ||
| if (argv.length !== 1) { | ||
| throw new Error('Expect WORKSPACE to be first parameter'); | ||
| } | ||
| const workspace = argv[0]; | ||
| const content = fs.readFileSync(workspace, 'utf-8'); | ||
| const regex = /ANGULAR_VERSION.*\nhttp_archive\((.*\n){4}\)/; | ||
| if (!regex.test(content)) { | ||
| throw new Error("Failed to find http_archive rule for Angular in WORKSPACE"); | ||
| } | ||
| const newContent = content.replace(regex, ` | ||
| local_repository( | ||
| name = "angular", | ||
| path = "../../..", | ||
| )`); | ||
| fs.writeFileSync(workspace, newContent); | ||
| } | ||
|
|
||
| main(process.argv) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.