fixup! docs: addresses PR comments

angular · Jan 25, 2020 · f450f03 · f450f03
1 parent e45a1f4
commit f450f03
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/aio/content/examples/comparing-observables/src/observables.spec.ts b/aio/content/examples/comparing-observables/src/observables.spec.ts
@@ -1,4 +1,3 @@
-import { map } from 'rxjs/operators';
 import { docRegionChain, docRegionObservable, docRegionUnsubscribe } from './observables';
 
 describe('observables', () => {
@@ -19,7 +18,7 @@ describe('observables', () => {
 
   it('should chain an observable', (doneFn: DoneFn) => {
     const observable = docRegionChain();
-    observable.pipe(map(v => 2 * v)).subscribe(value => {
+    observable.subscribe(value => {
       expect(value).toBe(4);
       doneFn();
     });

diff --git a/aio/content/examples/comparing-observables/src/observables.ts b/aio/content/examples/comparing-observables/src/observables.ts
@@ -47,21 +47,22 @@ export function docRegionUnsubscribe() {
 export function docRegionError() {
   const observable = new Observable<number>(observer => {
     // Subscriber fn...
-    observer.next(2);
   });
 
   // #docregion error
   observable.subscribe(() => {
-    throw Error('my error');
+    throw new Error('my error');
   });
   // #enddocregion error
 }
 
 export function docRegionChain() {
-  const observable = new Observable<number>(observer => {
+  let observable = new Observable<number>(observer => {
     // Subscriber fn...
     observer.next(2);
   });
+
+  observable = 
   // #docregion chain
 
   observable.pipe(map(v => 2 * v));

diff --git a/aio/content/examples/comparing-observables/src/promises.spec.ts b/aio/content/examples/comparing-observables/src/promises.spec.ts
@@ -12,11 +12,11 @@ describe('promises', () => {
   });
 
   it('should throw an error', (doneFn: DoneFn) => {
-    const pr = docRegionError();
-    pr
-    .then(()=> {})
-    .catch((d) => {
-      doneFn();
-    });
+    const promise = docRegionError();
+    promise
+      .then(() => {
+        throw new Error('Promise should be rejected.');
+      },
+        () => doneFn());
   });
 });
diff --git a/aio/content/examples/comparing-observables/src/promises.ts b/aio/content/examples/comparing-observables/src/promises.ts
@@ -35,7 +35,7 @@ export function docRegionError() {
   // #docregion error
 
   promise.then(() => {
-    throw Error('my error');
+    throw new Error('my error');
   })
 
   // #enddocregion error