fixup! test(docs-infra): add missing tests for obserables and promises

angular · Aug 27, 2020 · f9cc5b7 · f9cc5b7
1 parent ce7c6d0
commit f9cc5b7
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/aio/content/examples/comparing-observables/src/observables.ts b/aio/content/examples/comparing-observables/src/observables.ts
@@ -45,7 +45,7 @@ export function docRegionUnsubscribe() {
 }
 
 export function docRegionError() {
-  const observable = new Observable<number>(observer => {
+  const observable = new Observable<number>(() => {
     // Subscriber fn...
   });
 

diff --git a/aio/content/examples/comparing-observables/src/promises.spec.ts b/aio/content/examples/comparing-observables/src/promises.spec.ts
@@ -3,10 +3,11 @@ import { docRegionError, docRegionPromise } from './promises';
 describe('promises', () => {
   it('should print 2', (doneFn: DoneFn) => {
     const consoleLogSpy = spyOn(console, 'log');
-    const pr = docRegionPromise(console);
-    pr.then(() => {
+    const pr = docRegionPromise(console, 2);
+    pr.then((value) => {
       expect(consoleLogSpy).toHaveBeenCalledTimes(1);
       expect(consoleLogSpy).toHaveBeenCalledWith(2);
+      expect(value).toHaveBeenCalledWith(4);
       doneFn();
     });
   });

diff --git a/aio/content/examples/comparing-observables/src/promises.ts b/aio/content/examples/comparing-observables/src/promises.ts
@@ -1,31 +1,32 @@
 // #docplaster
 
-export function docRegionPromise(console: Console) {
+export function docRegionPromise(console: Console, inputValue: number) {
   // #docregion promise
   // initiate execution
-  const promise = new Promise<number>((resolve, reject) => {
+  let promise = new Promise<number>((resolve, reject) => {
     // Executer fn...
     // #enddocregion promise
     // The below is used in the unit tests.
-    resolve(2);
+    resolve(inputValue);
     // #docregion promise
   });
-
+  // #enddocregion promise
+  promise =
+  // #docregion promise
   promise.then(value => {
     // handle result here
     // #enddocregion promise
     // The below is used in the unit tests.
     console.log(value);
+    return value;
     // #docregion promise
   });
-
   // #enddocregion promise
-
+  promise =
   // #docregion chain
-
   promise.then(v => 2 * v);
-
   // #enddocregion chain
+
   return promise;
 }
 
@@ -36,7 +37,7 @@ export function docRegionError() {
 
   promise.then(() => {
     throw new Error('my error');
-  })
+  });
 
   // #enddocregion error
   return promise;