Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routerLink outside a link should have a tabindex property #10895

Closed
EmmanuelDemey opened this issue Aug 17, 2016 · 5 comments · Fixed by #13094
Closed

routerLink outside a link should have a tabindex property #10895

EmmanuelDemey opened this issue Aug 17, 2016 · 5 comments · Fixed by #13094
Labels
area: router feature Issue that requests a new feature freq1: low

Comments

@EmmanuelDemey
Copy link
Contributor

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[ x ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

When we use the routerLink directive on on element other than a link, the element may not be focusable

Expected/desired behavior

Like ngAria, we should make automatically an HTML element with routerLink focusable. We should add a tabindex if not defined already by the developer.

Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 2.0.0-rc.5
  • Browser: all
  • Language: all
@vsavkin vsavkin added the feature Issue that requests a new feature label Aug 19, 2016
DzmitryShylovich pushed a commit to DzmitryShylovich/angular that referenced this issue Nov 25, 2016
DzmitryShylovich pushed a commit to DzmitryShylovich/angular that referenced this issue Dec 3, 2016
DzmitryShylovich pushed a commit to DzmitryShylovich/angular that referenced this issue Dec 5, 2016
@gkalpak
Copy link
Member

gkalpak commented Dec 19, 2016

This doesn't really sound it should be routerLink's responsibility (e.g. the forms directives don't add all aria attributes they could). ARIA is a separate concern that should be handled consistently throughout the app, either by the developer or by a dedicated module/directives.

But I am too late to the party I guess 😕

@DzmitryShylovich
Copy link
Contributor

@gkalpak but tabindex is not an aria attribute.

@gkalpak
Copy link
Member

gkalpak commented Feb 15, 2017

I was referring to things whose purpose is to make the app more accessible in general.

@simeyla
Copy link

simeyla commented Feb 12, 2018

Took me too long to figure out what was happening with this one. I agree routerLink should not be setting tabindex on my behalf - at least not without an obvious way to NOT do it at all. I came across this when I tried to apply a routerLink to a mat-row in a mat-table and it just looks awful with a focused outline.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: router feature Issue that requests a new feature freq1: low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants