-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routerLink outside a link should have a tabindex property #10895
Comments
This doesn't really sound it should be But I am too late to the party I guess 😕 |
@gkalpak but |
I was referring to things whose purpose is to make the app more accessible in general. |
Took me too long to figure out what was happening with this one. I agree routerLink should not be setting tabindex on my behalf - at least not without an obvious way to NOT do it at all. I came across this when I tried to apply a routerLink to a mat-row in a mat-table and it just looks awful with a focused outline. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a ... (check one with "x")
Current behavior
When we use the routerLink directive on on element other than a link, the element may not be focusable
Expected/desired behavior
Like ngAria, we should make automatically an HTML element with routerLink focusable. We should add a tabindex if not defined already by the developer.
Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
What is the expected behavior?
What is the motivation / use case for changing the behavior?
Please tell us about your environment:
The text was updated successfully, but these errors were encountered: