ControlValueAccessor.setDisabledState is not reliably checked for presence before calling

[xealot]

I'm submitting a ... (check one with "x")

[x] bug report

Current behavior

The ControlValueAccessor interface recently received a new optional method, setDisabledState. There are places in the form handling code that do not check if the setDisabledState method is present before invoking it.

angular/modules/@angular/forms/src/directives/reactive_directives/form_control_directive.ts

Line 93 in 57cb820

if (this.control.disabled) this.valueAccessor.setDisabledState(true);

angular/modules/@angular/forms/src/directives/reactive_directives/form_control_name.ts

Line 150 in dd8204a

if (this.control.disabled) this.valueAccessor.setDisabledState(true);

Expected behavior

Setting disables state should either always be checked, implemented in some base class or abstract way or have some function that things can call to encapsulate the optional call.

Reproduction of the problem

Set disabled on a form with components that do not implement setDisabledState

• Angular version: 2.0.0
• Browser: all
• Language: all

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}